Skip to content

Commit 44dc19e

Browse files
fix(asap-tools): align the feed to every query group's interval
The feed's alignment and the aligned groups' checks read the first mode's client config, which for sketchdb may lack trailing groups; they now read a mode that runs every group. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 750aaeb commit 44dc19e

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

‎asap-tools/experiments/experiment_run_clickhouse.py‎

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -650,12 +650,17 @@ def main(cfg: DictConfig) -> None:
650650
paced_feeder_config["workload_table"] = os.path.abspath(
651651
paced_feeder_config["workload_table"]
652652
)
653-
# Every mode's client config has the same query timing.
653+
# Every mode but sketchdb runs every query group (sketchdb may skip
654+
# trailing ones), so any other mode's client config has them all.
655+
all_groups_mode = next(
656+
(m for m in experiment_modes if m != constants.SKETCHDB_EXPERIMENT_NAME),
657+
experiment_modes[0],
658+
)
654659
with open(
655660
os.path.join(
656661
local_experiment_root_dir,
657662
"controller_client_configs",
658-
f"{experiment_modes[0]}.yaml",
663+
f"{all_groups_mode}.yaml",
659664
)
660665
) as f:
661666
paced_feeder_align_secs = _check_clickhouse_paced_feeder(
@@ -776,7 +781,8 @@ def main(cfg: DictConfig) -> None:
776781
os.makedirs(local_experiment_dir, exist_ok=True)
777782

778783
if experiment_mode == constants.SKETCHDB_EXPERIMENT_NAME:
779-
# --- sketchdb mode: precompute engine + JSON ingest + ClickHouse fallback ---
784+
# --- sketchdb mode: precompute engine + ClickHouse fallback, ingesting
785+
# the paced feed (remote write) or local_data_file (JSON) ---
780786
asap_http_port = urlparse(mode_server_urls[experiment_mode]).port
781787
# Kill any leftover query_engine_rust from a previous run (mirrors
782788
# query_engine_service.stop() at the top of the e2e mode loop).

0 commit comments

Comments
 (0)