Commit 6826c52
fix(planner): sync Python subpopulation logic, drop redundant heap override
does_precompute_operator_support_subpopulations in the Python copy of
this function still returned False for CountMinSketchWithHeap + TOPK
with a stale comment, the same bug the Rust copy fixed for planner/SQL
in a prior commit. Update it to return True, matching Rust (the heap
is self-keyed but still tracks many keys internally, like MultipleSum).
Also remove the manual grouping/aggregated-label override for SQL
top-k in planner/sql.rs: build_agg_configs_for_statistics already
produces the same split via set_subpopulation_labels now that
does_precompute_operator_support_subpopulations returns true for this
case, so the override was dead code.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V66Z7Fge2EYW2N1CDJzrxk1 parent 0e0f2c5 commit 6826c52
2 files changed
Lines changed: 7 additions & 15 deletions
Lines changed: 6 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
101 | | - | |
102 | | - | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
103 | 106 | | |
104 | 107 | | |
105 | 108 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
144 | | - | |
| 144 | + | |
145 | 145 | | |
146 | 146 | | |
147 | 147 | | |
| |||
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
166 | | - | |
167 | | - | |
168 | | - | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | 166 | | |
178 | 167 | | |
179 | 168 | | |
| |||
0 commit comments