Skip to content

Commit 88132c2

Browse files
refactor(query-engine): remove legacy SimpleMapStore implementations (#625)
Legacy stores and their comparison benchmark were gated behind a feature flag but broke cargo clippy pre-commit; deleting them outright removes the flag and the failure. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
1 parent 8571055 commit 88132c2

6 files changed

Lines changed: 0 additions & 2064 deletions

File tree

‎asap-query-engine/Cargo.toml‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -84,11 +84,6 @@ path = "src/bin/e2e_quickstart_resource_test.rs"
8484
tempfile = "3.20.0"
8585
criterion = { version = "0.5", features = ["html_reports"] }
8686

87-
[[bench]]
88-
name = "simple_store_bench"
89-
harness = false
90-
required-features = ["legacy_stores"]
91-
9287
[features]
9388
#default = ["lock_profiling", "extra_debugging"]
9489
default = ["jemalloc"]
@@ -98,8 +93,3 @@ jemalloc = ["dep:tikv-jemallocator"]
9893
lock_profiling = []
9994
# Enable extra debugging output
10095
extra_debugging = []
101-
# Legacy SimpleMapStore implementations, kept only for the simple_store_bench
102-
# comparison benchmark. Off by default so the Store trait's real implementors
103-
# are just SimpleMapStoreGlobal/PerKey — adding a Store trait method doesn't
104-
# require updating the legacy variants.
105-
legacy_stores = []

0 commit comments

Comments
 (0)