Add ical_value property to VDatetime by Mrbozz · Pull Request #1991 · PyCalendar/icalendar

Mrbozz · 2026-10-21T03:23:04Z

Contribuites to issue #876

AI: I used Claude sonnet 5.5. It was used to:

Sumarize a bit of the modules I was working with
help me draft the tests
Review the code/docsstrings to verify if everything was alright

Linked issue

Contributes to Properly decode every value type (polymorphy, beginner) #876

Description

Added an Ical_value property to vDatetime and added some tests related to it

Checklist

I added a change log entry, following the instructions in all subsections under Change log requirements.
I followed icalendar's Artificial intelligence policy and disclosed my Responsible AI use in my commit messages, if applicable.
I added or updated tests, if applicable.
I ran and ensured all tests pass locally by following Run tests.
I added or edited documentation as necessary, both as docstrings to be rendered in the API documentation and narrative documentation, following the Style guide.

Added and documented the ical_value property, which returns the datetime held by vDatetime, and added tests for it. AI: I used Claude sonnet 5.5. It was used to: - Sumarize a bit of the modules I was working with - help me draft the tests - Review the code/docsstrings to verify if everything was alright

github-actions · 2026-10-21T03:23:13Z

Thanks for the pull request, @Mrbozz! A maintainer will review it shortly.

github-actions · 2026-10-21T03:23:14Z

Insufficient data

Not enough activity yet to make a reliable assessment.

View full analysis →

_{This is an automated analysis by AgentScan}

github-actions · 2026-10-21T03:23:15Z

This pull request did not pass quality checks and AI use is suspected. Please review Contribute and make any necessary amendments.

niccokunzmann

This is technically correct. Can you check if you have formatted the code and also the style?

We have the procedures documented. Let me know if you need help finding them.

niccokunzmann

Thanks! I left some suggestions....

Co-authored-by: Nicco Kunzmann <niccokunzmann@rambler.ru>

stevepiercy

Thank you for your contribution! I made a few suggestions. Would you please take care?

Co-authored-by: Steve Piercy <web@stevepiercy.com>

niccokunzmann

I pass this to @stevepiercy

angatha

Technically fine

niccokunzmann · 2026-10-27T18:14:34Z

@Mrbozz I think, you might need to rename the changelog entry now, adding a number like .1 at the end of the file.

stevepiercy

@Mrbozz thanks for your patience for a review and your contribution. I made a suggestion for a tweak to the docstring wording, and for a new test. Would you please take care? Thank you!

Co-authored-by: Steve Piercy <web@stevepiercy.com>

…tzinfo is been set to none when no timezone is given

A sugestion about the docstring was made , but when I applied it didnt delete the previous line so it was doubled, now I deleted the previous line

stevepiercy

Add line break for legibility. I'll commit this one.

stevepiercy

I'll commit this change, too.

stevepiercy

@Mrbozz thank you! This is good to automerge, once CI passes.

stevepiercy

OK, now I really approve.

stevepiercy · 2026-11-13T22:58:02Z

Wonky docs

De-wonkified docs

Mrbozz and others added 2 commits October 20, 2026 23:49

Merge branch 'collective:main' into main

2d5d0e9

Mrbozz requested review from angatha, niccokunzmann and stevepiercy as code owners October 21, 2026 03:23

github-actions Bot added the ai-suspicion This contribution is possibly created with lots of AI help without enough human understanding. label Oct 21, 2026

niccokunzmann mentioned this pull request Oct 21, 2026

Properly decode every value type (polymorphy, beginner) #876

Open

7 of 31 tasks

niccokunzmann requested changes Oct 21, 2026

View reviewed changes

Comment thread src/icalendar/prop/dt/datetime.py Resolved

Fixed docstring in ical_value and fixed ruff issues

d163f90

niccokunzmann requested changes Oct 21, 2026

View reviewed changes

Comment thread news/876.feature Resolved

Comment thread src/icalendar/prop/dt/datetime.py Resolved

Mrbozz and others added 4 commits October 21, 2026 15:11

Update src/icalendar/prop/dt/datetime.py

9009afb

Co-authored-by: Nicco Kunzmann <niccokunzmann@rambler.ru>

Corrected news message

df0d6a8

Merge branch 'main' of https://github.com/Mrbozz/icalendar

69b2309

Merge branch 'main' into main

10acdf4

stevepiercy requested changes Oct 21, 2026

View reviewed changes

Comment thread news/876.feature Resolved

Comment thread src/icalendar/prop/dt/datetime.py Resolved

Mrbozz and others added 5 commits October 21, 2026 20:34

Update news/876.feature

3ff3b75

Co-authored-by: Steve Piercy <web@stevepiercy.com>

Specified a bit better the return part of ical-value docstring

6d4a4cc

Merge branch 'main' into main

c5c666e

Merge branch 'main' into main

a3bcbf8

Added examples to ical_value docstrings to make it clearer

7c9cf4e

niccokunzmann previously approved these changes Oct 22, 2026

View reviewed changes

niccokunzmann assigned stevepiercy Oct 22, 2026

Merge branch 'main' into main

b76fcf8

angatha previously approved these changes Oct 25, 2026

View reviewed changes

Merge branch 'main' into main

887307c

renamed changelog entry

67d50dc

Mrbozz dismissed angatha’s stale review via 83c58ab October 29, 2026 19:54

Mrbozz and others added 8 commits October 29, 2026 16:56

removed old 876 from local project

5c94078

Merge branch 'main' into main

545dddc

Merge branch 'collective:main' into main

49c1286

Merge remote-tracking branch 'upstream/main'

e5e8766

Merge branch 'main' into main

03161c0

Merge branch 'main' into main

453ee82

Merge branch 'main' into main

fb2617e

Merge branch 'main' into main

def237f

stevepiercy requested changes Nov 10, 2026

View reviewed changes

Comment thread src/icalendar/prop/dt/datetime.py Resolved

Comment thread src/icalendar/tests/prop/test_vDatetime.py Resolved

Mrbozz and others added 7 commits November 10, 2026 08:18

Update src/icalendar/prop/dt/datetime.py

06b646d

Co-authored-by: Steve Piercy <web@stevepiercy.com>

Merge branch 'main' into main

650bdb9

Merge branch 'main' of https://github.com/Mrbozz/icalendar

b3edf74

added an extra assert to :test: 'test_ical_value_returns' to test if …

2651638

…tzinfo is been set to none when no timezone is given

Github apply suggestion didnt delete the previous line

964365f

A sugestion about the docstring was made , but when I applied it didnt delete the previous line so it was doubled, now I deleted the previous line

Merge branch 'main' into main

f3dd98b

Merge branch 'main' into main

fc34ea2

stevepiercy requested changes Nov 13, 2026

View reviewed changes

Comment thread src/icalendar/prop/dt/datetime.py Resolved

Update src/icalendar/prop/dt/datetime.py

5637512

stevepiercy requested changes Nov 13, 2026

View reviewed changes

Comment thread src/icalendar/tests/prop/test_vDatetime.py Resolved

Update src/icalendar/tests/prop/test_vDatetime.py

8a8f476

stevepiercy requested changes Nov 13, 2026

View reviewed changes

Comment thread src/icalendar/tests/prop/test_vDatetime.py Resolved

Update src/icalendar/tests/prop/test_vDatetime.py

e920fa2

stevepiercy enabled auto-merge (squash) November 13, 2026 22:43

stevepiercy approved these changes Nov 13, 2026

View reviewed changes

stevepiercy requested changes Nov 13, 2026

View reviewed changes

Comment thread src/icalendar/prop/dt/datetime.py Resolved

Update src/icalendar/prop/dt/datetime.py

47869e4

stevepiercy approved these changes Nov 13, 2026

View reviewed changes

stevepiercy merged commit 982640a into PyCalendar:main Nov 13, 2026
42 checks passed

Conversation

Mrbozz commented Oct 21, 2026

Linked issue

Description

Checklist

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

github-actions Bot commented Oct 21, 2026

Insufficient data

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

niccokunzmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

niccokunzmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stevepiercy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

niccokunzmann left a comment

Choose a reason for hiding this comment

Uh oh!

angatha left a comment

Choose a reason for hiding this comment

Uh oh!

niccokunzmann commented Oct 27, 2026

Uh oh!

stevepiercy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stevepiercy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stevepiercy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stevepiercy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stevepiercy left a comment

Choose a reason for hiding this comment

Uh oh!

stevepiercy commented Nov 13, 2026

Wonky docs

De-wonkified docs

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants