cleanup

Author: SimonCropp

src/Polyfill/StringPolyfill.cs

@@ -7,7 +7,6 @@
 namespace Polyfills;
 
 using System;
-using System.Buffers;
 using System.Collections.Generic;
 
 static partial class Polyfill
@@ -252,7 +251,8 @@ public static string Create<TState>(int length, TState state, System.Buffers.Spa
 
             return str;
 #else
-            var chars = ArrayPool<char>.Shared.Rent(length);
+            var pool = System.Buffers.ArrayPool<char>.Shared;
+            var chars = pool.Rent(length);
 
             try
             {
@@ -266,7 +266,7 @@ public static string Create<TState>(int length, TState state, System.Buffers.Spa
             }
             finally
             {
-                ArrayPool<char>.Shared.Return(chars);
+                pool.Return(chars);
             }
 #endif
         }

src/Tests/SanityChecks.cs

@@ -88,6 +88,8 @@ public void ReflectionChecks()
                 name == "ParamCollectionAttribute" ||
                 name == "NativeIntegerAttribute" ||
                 name == "ExtensionMarkerAttribute" ||
+                name == "ReadOnlySpanAction`2" ||
+                name == "SpanAction`2" ||
                 name == "FileUtil")
             {
                 continue;

src/Tests/StringPolyfillTests.cs

@@ -1,5 +1,7 @@
 // ReSharper disable RedundantExplicitParamsArrayCreation
+// ReSharper disable ReplaceSliceWithRangeIndexer
 [TestFixture]
+[SuppressMessage("Style", "IDE0057:Use range operator")]
 public class StringPolyfillTest
 {
     [Test]
@@ -72,7 +74,7 @@ public void Create_WithStateObject_UsesStateCorrectly()
             {
                 s.first.AsSpan().CopyTo(span);
                 span[5] = ' ';
-                s.second.AsSpan()[..4].CopyTo(span[6..]);
+                s.second.AsSpan().Slice(0, 4).CopyTo(span.Slice(6));
             });
 
         Assert.That(result, Is.EqualTo("Hello Worl"));
@@ -149,20 +151,20 @@ public void Create_WithComplexState_PreservesAllData()
 
                 // Write ID
                 var idStr = s.Id.ToString();
-                idStr.AsSpan().CopyTo(span[pos..]);
+                idStr.AsSpan().CopyTo(span.Slice(pos));
                 pos += idStr.Length;
 
                 span[pos++] = '-';
 
                 // Write Name
-                s.Name.AsSpan().CopyTo(span[pos..]);
+                s.Name.AsSpan().CopyTo(span.Slice(pos));
                 pos += s.Name.Length;
 
                 span[pos++] = '-';
 
                 // Write IsActive
                 var activeStr = s.IsActive ? "True" : "False";
-                activeStr.AsSpan().CopyTo(span[pos..]);
+                activeStr.AsSpan().CopyTo(span.Slice(pos));
             });
 
         Assert.That(result, Is.EqualTo("123-Test-True\0\0\0\0\0\0\0"));