Skip to content

Extract the repeated staking check into a helper #427

Description

@mikewheeleer

Helper for staking

Description

staking repeats an inline check. This issue extracts a shared helper.

Requirements and context

  • Repository scope: StableRoute-Org/Stableroute-contracts only.
  • Extract staking's repeated check into a helper returning a typed error; reuse at each call site.
  • Behaviour identical.
  • Tests pass.

Suggested execution

  • Fork the repo and create a branch
  • git checkout -b refactor/staking-91-helper
  • Implement changes
    • Write code in: the relevant module.
    • Write comprehensive tests in: cover the new behaviour and edge cases.
  • Test and commit

Test and commit

  • Run cargo fmt, cargo clippy --all-targets -- -D warnings, and cargo test.
  • Cover edge cases: same rejections, tests pass.
  • Include the full test output in the PR description.

Example commit message

refactor(staking): extract shared check

Guidelines

  • Minimum 95 percent test coverage for impacted modules.
  • Clear, reviewer-focused documentation.
  • Timeframe: 96 hours.

Community & contribution rewards

  • 💬 Join the StableRoute community on Discord: https://discord.gg/37aCpusvx
  • ⭐ This is a GrantFox OSS / Official Campaign task and may be rewarded. When your PR is merged you'll be prompted to rate the project — a 5-star rating is much appreciated.

Metadata

Metadata

Assignees

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions