Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 13, 2025

Pull request

Proposed changes

Implements three documentation tasks:

Both new pages follow repository conventions with proper YAML front matter (lang: de-CH), include cross-references to related docs (Corporate Identity, Kommunikationsrichtlinien), and auto-populate in the Interna section listing.

Types of changes

  • New feature (non-breaking change which adds functionality).
  • Enhancement (non-breaking change which enhances functionality)
  • Bug Fix (non-breaking change which fixes an issue).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist

  • I have read the README document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
Original prompt

implement #65 #66 #70


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 13, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI changed the title [WIP] Implement changes for issues 65, 66, and 70 Implement documentation for issues #65, #66, #70 Nov 13, 2025
Copilot AI requested a review from maehr November 13, 2025 09:03
@maehr maehr marked this pull request as ready for review December 8, 2025 07:23
Copilot AI review requested due to automatic review settings December 8, 2025 07:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements documentation for three GitHub issues (#65, #66, #70), adding comprehensive internal documentation for the Stadt.Geschichte.Basel project. The PR confirms that all .qmd files already contain explicit language tags (issue #65), and introduces two new documentation pages covering OMP Subpress styling and Hypotheses.org blog integration, plus a new wiki usage guide.

Key Changes:

  • New documentation for Confluence Wiki usage guidelines with naming conventions and organizational structure
  • New technical documentation for OMP Subpress custom styling, including Base64 font embedding and accessibility considerations
  • New comprehensive guide for Hypotheses.org blog CMS integration with editorial workflows and communication strategy

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
products/interna/wiki/index.qmd New comprehensive documentation for Confluence Wiki usage, including structure, naming conventions, tagging, and responsibilities
products/interna/stadtgeschichte-gesamtkonzept/index.qmd Language tag updated from de-DE to de for more generic German locale
products/interna/omp-styling/index.qmd New technical documentation covering custom CSS styling for OMP Subpress, including Base64-encoded fonts, color scheme, and accessibility features
products/interna/blog-cms/index.qmd New comprehensive documentation for Hypotheses.org blog platform, covering platform rationale, editorial guidelines, workflows, and integration with communication strategy

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

affiliation: Universität Basel
date: 2014-06
lang: de-DE
lang: de
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The language tag is changed from de-DE to de. While this makes it more generic, most other documentation files in the products/interna directory use lang: de-CH for consistency. Consider using de-CH to maintain consistency across the documentation, unless there's a specific reason this document should use the generic de tag.

Suggested change
lang: de
lang: de-CH

Copilot uses AI. Check for mistakes.

Für wiederkehrende Aufgaben stehen im Bereich "Corporate Identity" und "Vorlagen" entsprechende Templates bereit.

* **Sitzungsprotokolle:** Bitte die Standard-Vorlage für Meeting nutzen.
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence "Bitte die Standard-Vorlage für Meeting nutzen." is grammatically incomplete. It should be either "Bitte nutzen Sie die Standard-Vorlage für Meetings." (formal imperative with plural) or "Bitte die Standard-Vorlage für Meetings nutzen." (with plural noun).

Suggested change
* **Sitzungsprotokolle:** Bitte die Standard-Vorlage für Meeting nutzen.
* **Sitzungsprotokolle:** Bitte die Standard-Vorlage für Meetings nutzen.

Copilot uses AI. Check for mistakes.
@maehr maehr requested a review from mtwente December 8, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants