-
Notifications
You must be signed in to change notification settings - Fork 3
Implement documentation for issues #65, #66, #70 #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Comment |
Co-authored-by: maehr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements documentation for three GitHub issues (#65, #66, #70), adding comprehensive internal documentation for the Stadt.Geschichte.Basel project. The PR confirms that all .qmd files already contain explicit language tags (issue #65), and introduces two new documentation pages covering OMP Subpress styling and Hypotheses.org blog integration, plus a new wiki usage guide.
Key Changes:
- New documentation for Confluence Wiki usage guidelines with naming conventions and organizational structure
- New technical documentation for OMP Subpress custom styling, including Base64 font embedding and accessibility considerations
- New comprehensive guide for Hypotheses.org blog CMS integration with editorial workflows and communication strategy
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| products/interna/wiki/index.qmd | New comprehensive documentation for Confluence Wiki usage, including structure, naming conventions, tagging, and responsibilities |
| products/interna/stadtgeschichte-gesamtkonzept/index.qmd | Language tag updated from de-DE to de for more generic German locale |
| products/interna/omp-styling/index.qmd | New technical documentation covering custom CSS styling for OMP Subpress, including Base64-encoded fonts, color scheme, and accessibility features |
| products/interna/blog-cms/index.qmd | New comprehensive documentation for Hypotheses.org blog platform, covering platform rationale, editorial guidelines, workflows, and integration with communication strategy |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| affiliation: Universität Basel | ||
| date: 2014-06 | ||
| lang: de-DE | ||
| lang: de |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The language tag is changed from de-DE to de. While this makes it more generic, most other documentation files in the products/interna directory use lang: de-CH for consistency. Consider using de-CH to maintain consistency across the documentation, unless there's a specific reason this document should use the generic de tag.
| lang: de | |
| lang: de-CH |
|
|
||
| Für wiederkehrende Aufgaben stehen im Bereich "Corporate Identity" und "Vorlagen" entsprechende Templates bereit. | ||
|
|
||
| * **Sitzungsprotokolle:** Bitte die Standard-Vorlage für Meeting nutzen. |
Copilot
AI
Dec 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sentence "Bitte die Standard-Vorlage für Meeting nutzen." is grammatically incomplete. It should be either "Bitte nutzen Sie die Standard-Vorlage für Meetings." (formal imperative with plural) or "Bitte die Standard-Vorlage für Meetings nutzen." (with plural noun).
| * **Sitzungsprotokolle:** Bitte die Standard-Vorlage für Meeting nutzen. | |
| * **Sitzungsprotokolle:** Bitte die Standard-Vorlage für Meetings nutzen. |
Pull request
Proposed changes
Implements three documentation tasks:
lang:in YAML headers #65: Verified all 76 .qmd files already contain explicitlang:YAML fields. No changes required.products/interna/omp-styling/index.qmd. Covers base64-encoded font embedding (Euclid Circular B), color scheme implementation, and accessibility considerations.products/interna/blog-cms/index.qmd. Covers platform rationale, editorial workflows, and integration with communication strategy.Both new pages follow repository conventions with proper YAML front matter (
lang: de-CH), include cross-references to related docs (Corporate Identity, Kommunikationsrichtlinien), and auto-populate in the Interna section listing.Types of changes
Checklist
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.