From 7a6baa007bdeed541d21710ff89dab01aa2e76c4 Mon Sep 17 00:00:00 2001 From: Minhajuddin Mohammed Date: Wed, 28 Jan 2026 12:00:54 -0500 Subject: [PATCH] Refine processing banner display logic Updated logic to prevent showing processing banner when there are no resources being processed or on error. --- ckanext/scheming/assets/js/scheming-suggestions.js | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/ckanext/scheming/assets/js/scheming-suggestions.js b/ckanext/scheming/assets/js/scheming-suggestions.js index c497d50a9..31b38ec20 100644 --- a/ckanext/scheming/assets/js/scheming-suggestions.js +++ b/ckanext/scheming/assets/js/scheming-suggestions.js @@ -383,12 +383,12 @@ ckan.module('scheming-suggestions', function($) { if (!status || !self.options.terminalStatuses.includes(status.toUpperCase())) { self._showProcessingBanner(); } - } else { - self._showProcessingBanner(); } + // If dpp_suggestions doesn't exist, don't show the banner + // (dataset has no resources being processed) }, error: function() { - self._showProcessingBanner(); + // Don't show banner on error - dataset might just be new } }); } @@ -405,6 +405,14 @@ ckan.module('scheming-suggestions', function($) { var datasetObject = response.result; var dppSuggestionsData = datasetObject.dpp_suggestions; // This is the direct JSON object + // If dpp_suggestions doesn't exist at all, this dataset has no resources being processed + if (!dppSuggestionsData) { + console.log("SchemingSuggestions: No dpp_suggestions field found. Dataset has no resources being processed."); + self._showAllButtonsAsNoSuggestion(); + globalState.isPolling = false; + return; + } + if (dppSuggestionsData && dppSuggestionsData.package) { self._processDppButtonSuggestions(dppSuggestionsData.package); } else {