diff --git a/Core/GameEngine/Source/Common/INI/INI.cpp b/Core/GameEngine/Source/Common/INI/INI.cpp index a59d2b0b6fc..064819ed561 100644 --- a/Core/GameEngine/Source/Common/INI/INI.cpp +++ b/Core/GameEngine/Source/Common/INI/INI.cpp @@ -1828,7 +1828,7 @@ void INI::parseAccelerationReal( INI *ini, void * /*instance*/, void *store, con void INI::parseVeterancyLevelFlags(INI* ini, void* /*instance*/, void* store, const void* /*userData*/) { VeterancyLevelFlags flags = VETERANCY_LEVEL_FLAGS_ALL; - for (const char* token = ini->getNextToken(); token; token = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token; token = ini->getNextTokenOrNull()) { if (stricmp(token, "ALL") == 0) { @@ -1867,12 +1867,10 @@ void INI::parseSoundsList( INI* ini, void *instance, void *store, const void* /* std::vector *vec = (std::vector*) store; vec->clear(); - const char* SEPS = " \t,="; - const char *c = ini->getNextTokenOrNull(SEPS); - while ( c ) + constexpr const char* SEPS = " \t,="; + for (const char* token = ini->getNextTokenOrNull(SEPS); token; token = ini->getNextTokenOrNull(SEPS)) { - vec->push_back( c ); - c = ini->getNextTokenOrNull(SEPS); + vec->push_back(token); } } @@ -1881,8 +1879,7 @@ void INI::parseSoundsList( INI* ini, void *instance, void *store, const void* /* void INI::parseDamageTypeFlags(INI* ini, void* /*instance*/, void* store, const void* /*userData*/) { DamageTypeFlags flags = DAMAGE_TYPE_FLAGS_ALL; - - for (const char* token = ini->getNextToken(); token; token = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token; token = ini->getNextTokenOrNull()) { if (stricmp(token, "ALL") == 0) { @@ -1916,7 +1913,7 @@ void INI::parseDamageTypeFlags(INI* ini, void* /*instance*/, void* store, const void INI::parseDeathTypeFlags(INI* ini, void* /*instance*/, void* store, const void* /*userData*/) { DeathTypeFlags flags = DEATH_TYPE_FLAGS_ALL; - for (const char* token = ini->getNextToken(); token; token = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token; token = ini->getNextTokenOrNull()) { if (stricmp(token, "ALL") == 0) { diff --git a/Generals/Code/GameEngine/Source/Common/Thing/ThingTemplate.cpp b/Generals/Code/GameEngine/Source/Common/Thing/ThingTemplate.cpp index a3decd3c458..52d04df5f1d 100644 --- a/Generals/Code/GameEngine/Source/Common/Thing/ThingTemplate.cpp +++ b/Generals/Code/GameEngine/Source/Common/Thing/ThingTemplate.cpp @@ -548,7 +548,7 @@ static void parsePrerequisiteUnit( INI* ini, void *instance, void * /*store*/, c ProductionPrerequisite prereq; Bool orUnitWithPrevious = FALSE; - for (const char *token = ini->getNextToken(); token != nullptr; token = ini->getNextTokenOrNull()) + for (const char *token = ini->getNextTokenOrNull(); token != nullptr; token = ini->getNextTokenOrNull()) { prereq.addUnitPrereq( AsciiString( token ), orUnitWithPrevious ); orUnitWithPrevious = TRUE; diff --git a/Generals/Code/GameEngine/Source/GameLogic/AI/TurretAI.cpp b/Generals/Code/GameEngine/Source/GameLogic/AI/TurretAI.cpp index cbae6d63d4f..1a58df02a62 100644 --- a/Generals/Code/GameEngine/Source/GameLogic/AI/TurretAI.cpp +++ b/Generals/Code/GameEngine/Source/GameLogic/AI/TurretAI.cpp @@ -202,12 +202,10 @@ TurretAIData::TurretAIData() static void parseTWS(INI* ini, void * /*instance*/, void * store, const void* /*userData*/) { UnsignedInt* tws = (UnsignedInt*)store; - const char* token = ini->getNextToken(); - while (token != nullptr) + for (const char* token = ini->getNextTokenOrNull(); token; token = ini->getNextTokenOrNull()) { WeaponSlotType wslot = (WeaponSlotType)INI::scanIndexList(token, TheWeaponSlotTypeNames); *tws |= (1 << wslot); - token = ini->getNextTokenOrNull(); } } diff --git a/Generals/Code/GameEngine/Source/GameLogic/Object/Behavior/InstantDeathBehavior.cpp b/Generals/Code/GameEngine/Source/GameLogic/Object/Behavior/InstantDeathBehavior.cpp index 3321c0b025d..cbaa710b884 100644 --- a/Generals/Code/GameEngine/Source/GameLogic/Object/Behavior/InstantDeathBehavior.cpp +++ b/Generals/Code/GameEngine/Source/GameLogic/Object/Behavior/InstantDeathBehavior.cpp @@ -62,7 +62,7 @@ InstantDeathBehaviorModuleData::InstantDeathBehaviorModuleData() static void parseFX( INI* ini, void *instance, void * /*store*/, const void* /*userData*/ ) { InstantDeathBehaviorModuleData* self = (InstantDeathBehaviorModuleData*)instance; - for (const char* token = ini->getNextToken(); token != nullptr; token = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token != nullptr; token = ini->getNextTokenOrNull()) { const FXList *fxl = TheFXListStore->findFXList((token)); // could be null! this is OK! self->m_fx.push_back(fxl); @@ -73,7 +73,7 @@ static void parseFX( INI* ini, void *instance, void * /*store*/, const void* /*u static void parseOCL( INI* ini, void *instance, void * /*store*/, const void* /*userData*/ ) { InstantDeathBehaviorModuleData* self = (InstantDeathBehaviorModuleData*)instance; - for (const char* token = ini->getNextToken(); token != nullptr; token = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token != nullptr; token = ini->getNextTokenOrNull()) { const ObjectCreationList *ocl = TheObjectCreationListStore->findObjectCreationList(token); // could be null! this is OK! self->m_ocls.push_back(ocl); @@ -84,7 +84,7 @@ static void parseOCL( INI* ini, void *instance, void * /*store*/, const void* /* static void parseWeapon( INI* ini, void *instance, void * /*store*/, const void* /*userData*/ ) { InstantDeathBehaviorModuleData* self = (InstantDeathBehaviorModuleData*)instance; - for (const char* token = ini->getNextToken(); token != nullptr; token = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token != nullptr; token = ini->getNextTokenOrNull()) { const WeaponTemplate *wt = TheWeaponStore->findWeaponTemplate(token); // could be null! this is OK! self->m_weapons.push_back(wt); diff --git a/Generals/Code/GameEngine/Source/GameLogic/Object/Behavior/SlowDeathBehavior.cpp b/Generals/Code/GameEngine/Source/GameLogic/Object/Behavior/SlowDeathBehavior.cpp index 5f52385005c..84bb7681a89 100644 --- a/Generals/Code/GameEngine/Source/GameLogic/Object/Behavior/SlowDeathBehavior.cpp +++ b/Generals/Code/GameEngine/Source/GameLogic/Object/Behavior/SlowDeathBehavior.cpp @@ -81,7 +81,7 @@ static void parseFX( INI* ini, void *instance, void * /*store*/, const void* /*u { SlowDeathBehaviorModuleData* self = (SlowDeathBehaviorModuleData*)instance; SlowDeathPhaseType sdphase = (SlowDeathPhaseType)INI::scanIndexList(ini->getNextToken(), TheSlowDeathPhaseNames); - for (const char* token = ini->getNextToken(); token != nullptr; token = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token != nullptr; token = ini->getNextTokenOrNull()) { const FXList *fxl = TheFXListStore->findFXList((token)); // could be null! this is OK! self->m_fx[sdphase].push_back(fxl); @@ -95,7 +95,7 @@ static void parseOCL( INI* ini, void *instance, void * /*store*/, const void* /* { SlowDeathBehaviorModuleData* self = (SlowDeathBehaviorModuleData*)instance; SlowDeathPhaseType sdphase = (SlowDeathPhaseType)INI::scanIndexList(ini->getNextToken(), TheSlowDeathPhaseNames); - for (const char* token = ini->getNextToken(); token != nullptr; token = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token != nullptr; token = ini->getNextTokenOrNull()) { const ObjectCreationList *ocl = TheObjectCreationListStore->findObjectCreationList(token); // could be null! this is OK! self->m_ocls[sdphase].push_back(ocl); @@ -109,7 +109,7 @@ static void parseWeapon( INI* ini, void *instance, void * /*store*/, const void* { SlowDeathBehaviorModuleData* self = (SlowDeathBehaviorModuleData*)instance; SlowDeathPhaseType sdphase = (SlowDeathPhaseType)INI::scanIndexList(ini->getNextToken(), TheSlowDeathPhaseNames); - for (const char* token = ini->getNextToken(); token != nullptr; token = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token != nullptr; token = ini->getNextTokenOrNull()) { const WeaponTemplate *wt = TheWeaponStore->findWeaponTemplate(token); // could be null! this is OK! self->m_weapons[sdphase].push_back(wt); diff --git a/Generals/Code/GameEngine/Source/GameLogic/Object/ObjectCreationList.cpp b/Generals/Code/GameEngine/Source/GameLogic/Object/ObjectCreationList.cpp index c3508284362..32645feca24 100644 --- a/Generals/Code/GameEngine/Source/GameLogic/Object/ObjectCreationList.cpp +++ b/Generals/Code/GameEngine/Source/GameLogic/Object/ObjectCreationList.cpp @@ -1351,12 +1351,11 @@ class GenericObjectCreationNugget : public ObjectCreationNugget static void parseDebrisObjectNames( INI* ini, void *instance, void *store, const void* /*userData*/ ) { GenericObjectCreationNugget* debrisNugget = (GenericObjectCreationNugget*)instance; - for (const char* debrisName = ini->getNextToken(); debrisName; debrisName = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token; token = ini->getNextTokenOrNull()) { if (TheGlobalData->m_preloadAssets) - debrisModelNamesGlobalHack.push_back(debrisName); - debrisNugget->m_names.push_back(AsciiString(debrisName)); - debrisName = ini->getNextTokenOrNull(); + debrisModelNamesGlobalHack.push_back(token); + debrisNugget->m_names.push_back(AsciiString(token)); } } diff --git a/Generals/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate.cpp b/Generals/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate.cpp index dd3b07d378d..0125cd58d49 100644 --- a/Generals/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate.cpp +++ b/Generals/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate.cpp @@ -172,16 +172,16 @@ const LocomotorTemplateVector* AIUpdateModuleData::findLocomotorTemplateVector(L } self->m_locomotorTemplates[set].clear(); - for (const char* locoName = ini->getNextToken(); locoName; locoName = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token; token = ini->getNextTokenOrNull()) { - if (!*locoName || stricmp(locoName, "None") == 0) + if (!*token || stricmp(token, "None") == 0) continue; - NameKeyType locoKey = NAMEKEY(locoName); + NameKeyType locoKey = NAMEKEY(token); const LocomotorTemplate* lt = TheLocomotorStore->findLocomotorTemplate(locoKey); if (!lt) { - DEBUG_CRASH(("Locomotor %s not found!",locoName)); + DEBUG_CRASH(("Locomotor %s not found!",token)); throw INI_INVALID_DATA; } self->m_locomotorTemplates[set].push_back(lt); diff --git a/Generals/Code/GameEngine/Source/GameLogic/Object/Update/StructureCollapseUpdate.cpp b/Generals/Code/GameEngine/Source/GameLogic/Object/Update/StructureCollapseUpdate.cpp index ab594a822f3..4adf66fccf8 100644 --- a/Generals/Code/GameEngine/Source/GameLogic/Object/Update/StructureCollapseUpdate.cpp +++ b/Generals/Code/GameEngine/Source/GameLogic/Object/Update/StructureCollapseUpdate.cpp @@ -84,7 +84,7 @@ static void parseFX( INI* ini, void *instance, void * /*store*/, const void* /*u { StructureCollapseUpdateModuleData* self = (StructureCollapseUpdateModuleData*)instance; StructureCollapsePhaseType scphase = (StructureCollapsePhaseType)INI::scanIndexList(ini->getNextToken(), TheStructureCollapsePhaseNames); - for (const char* token = ini->getNextToken(); token != nullptr; token = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token != nullptr; token = ini->getNextTokenOrNull()) { const FXList *fxl = TheFXListStore->findFXList((token)); // could be null! this is OK! self->m_fxs[scphase].push_back(fxl); @@ -96,7 +96,7 @@ static void parseOCL( INI* ini, void *instance, void * /*store*/, const void* /* { StructureCollapseUpdateModuleData* self = (StructureCollapseUpdateModuleData*)instance; StructureCollapsePhaseType stphase = (StructureCollapsePhaseType)INI::scanIndexList(ini->getNextToken(), TheStructureCollapsePhaseNames); - for (const char* token = ini->getNextToken(); token != nullptr; token = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token != nullptr; token = ini->getNextTokenOrNull()) { const ObjectCreationList *ocl = TheObjectCreationListStore->findObjectCreationList(token); // could be null! this is OK! self->m_ocls[stphase].push_back(ocl); diff --git a/Generals/Code/GameEngine/Source/GameLogic/Object/Update/StructureToppleUpdate.cpp b/Generals/Code/GameEngine/Source/GameLogic/Object/Update/StructureToppleUpdate.cpp index 4a1235e6c3c..18b3b7c7653 100644 --- a/Generals/Code/GameEngine/Source/GameLogic/Object/Update/StructureToppleUpdate.cpp +++ b/Generals/Code/GameEngine/Source/GameLogic/Object/Update/StructureToppleUpdate.cpp @@ -83,7 +83,7 @@ static void parseOCL( INI* ini, void *instance, void * /*store*/, const void* /* { StructureToppleUpdateModuleData* self = (StructureToppleUpdateModuleData*)instance; StructureTopplePhaseType stphase = (StructureTopplePhaseType)INI::scanIndexList(ini->getNextToken(), TheStructureTopplePhaseNames); - for (const char* token = ini->getNextToken(); token != nullptr; token = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token != nullptr; token = ini->getNextTokenOrNull()) { const ObjectCreationList *ocl = TheObjectCreationListStore->findObjectCreationList(token); // could be null! this is OK! self->m_ocls[stphase].push_back(ocl); diff --git a/GeneralsMD/Code/GameEngine/Source/Common/Thing/ThingTemplate.cpp b/GeneralsMD/Code/GameEngine/Source/Common/Thing/ThingTemplate.cpp index 54e8b295c96..a528d67f79a 100644 --- a/GeneralsMD/Code/GameEngine/Source/Common/Thing/ThingTemplate.cpp +++ b/GeneralsMD/Code/GameEngine/Source/Common/Thing/ThingTemplate.cpp @@ -630,7 +630,7 @@ static void parsePrerequisiteUnit( INI* ini, void *instance, void * /*store*/, c ProductionPrerequisite prereq; Bool orUnitWithPrevious = FALSE; - for (const char *token = ini->getNextToken(); token != nullptr; token = ini->getNextTokenOrNull()) + for (const char *token = ini->getNextTokenOrNull(); token != nullptr; token = ini->getNextTokenOrNull()) { prereq.addUnitPrereq( AsciiString( token ), orUnitWithPrevious ); orUnitWithPrevious = TRUE; diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/AI/TurretAI.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/AI/TurretAI.cpp index 55f4421c41e..cd2693f7426 100644 --- a/GeneralsMD/Code/GameEngine/Source/GameLogic/AI/TurretAI.cpp +++ b/GeneralsMD/Code/GameEngine/Source/GameLogic/AI/TurretAI.cpp @@ -202,12 +202,10 @@ TurretAIData::TurretAIData() static void parseTWS(INI* ini, void * /*instance*/, void * store, const void* /*userData*/) { UnsignedInt* tws = (UnsignedInt*)store; - const char* token = ini->getNextToken(); - while (token != nullptr) + for (const char* token = ini->getNextTokenOrNull(); token; token = ini->getNextTokenOrNull()) { WeaponSlotType wslot = (WeaponSlotType)INI::scanIndexList(token, TheWeaponSlotTypeNames); *tws |= (1 << wslot); - token = ini->getNextTokenOrNull(); } } diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Behavior/InstantDeathBehavior.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Behavior/InstantDeathBehavior.cpp index 52a2c56f61a..7c25f27c3eb 100644 --- a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Behavior/InstantDeathBehavior.cpp +++ b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Behavior/InstantDeathBehavior.cpp @@ -62,7 +62,7 @@ InstantDeathBehaviorModuleData::InstantDeathBehaviorModuleData() static void parseFX( INI* ini, void *instance, void * /*store*/, const void* /*userData*/ ) { InstantDeathBehaviorModuleData* self = (InstantDeathBehaviorModuleData*)instance; - for (const char* token = ini->getNextToken(); token != nullptr; token = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token != nullptr; token = ini->getNextTokenOrNull()) { const FXList *fxl = TheFXListStore->findFXList((token)); // could be null! this is OK! self->m_fx.push_back(fxl); @@ -73,7 +73,7 @@ static void parseFX( INI* ini, void *instance, void * /*store*/, const void* /*u static void parseOCL( INI* ini, void *instance, void * /*store*/, const void* /*userData*/ ) { InstantDeathBehaviorModuleData* self = (InstantDeathBehaviorModuleData*)instance; - for (const char* token = ini->getNextToken(); token != nullptr; token = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token != nullptr; token = ini->getNextTokenOrNull()) { const ObjectCreationList *ocl = TheObjectCreationListStore->findObjectCreationList(token); // could be null! this is OK! self->m_ocls.push_back(ocl); @@ -84,7 +84,7 @@ static void parseOCL( INI* ini, void *instance, void * /*store*/, const void* /* static void parseWeapon( INI* ini, void *instance, void * /*store*/, const void* /*userData*/ ) { InstantDeathBehaviorModuleData* self = (InstantDeathBehaviorModuleData*)instance; - for (const char* token = ini->getNextToken(); token != nullptr; token = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token != nullptr; token = ini->getNextTokenOrNull()) { const WeaponTemplate *wt = TheWeaponStore->findWeaponTemplate(token); // could be null! this is OK! self->m_weapons.push_back(wt); diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Behavior/SlowDeathBehavior.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Behavior/SlowDeathBehavior.cpp index fbdd8a62a24..d8d9e353257 100644 --- a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Behavior/SlowDeathBehavior.cpp +++ b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Behavior/SlowDeathBehavior.cpp @@ -81,7 +81,7 @@ static void parseFX( INI* ini, void *instance, void * /*store*/, const void* /*u { SlowDeathBehaviorModuleData* self = (SlowDeathBehaviorModuleData*)instance; SlowDeathPhaseType sdphase = (SlowDeathPhaseType)INI::scanIndexList(ini->getNextToken(), TheSlowDeathPhaseNames); - for (const char* token = ini->getNextToken(); token != nullptr; token = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token != nullptr; token = ini->getNextTokenOrNull()) { const FXList *fxl = TheFXListStore->findFXList((token)); // could be null! this is OK! self->m_fx[sdphase].push_back(fxl); @@ -95,7 +95,7 @@ static void parseOCL( INI* ini, void *instance, void * /*store*/, const void* /* { SlowDeathBehaviorModuleData* self = (SlowDeathBehaviorModuleData*)instance; SlowDeathPhaseType sdphase = (SlowDeathPhaseType)INI::scanIndexList(ini->getNextToken(), TheSlowDeathPhaseNames); - for (const char* token = ini->getNextToken(); token != nullptr; token = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token != nullptr; token = ini->getNextTokenOrNull()) { const ObjectCreationList *ocl = TheObjectCreationListStore->findObjectCreationList(token); // could be null! this is OK! self->m_ocls[sdphase].push_back(ocl); @@ -109,7 +109,7 @@ static void parseWeapon( INI* ini, void *instance, void * /*store*/, const void* { SlowDeathBehaviorModuleData* self = (SlowDeathBehaviorModuleData*)instance; SlowDeathPhaseType sdphase = (SlowDeathPhaseType)INI::scanIndexList(ini->getNextToken(), TheSlowDeathPhaseNames); - for (const char* token = ini->getNextToken(); token != nullptr; token = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token != nullptr; token = ini->getNextTokenOrNull()) { const WeaponTemplate *wt = TheWeaponStore->findWeaponTemplate(token); // could be null! this is OK! self->m_weapons[sdphase].push_back(wt); diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/ObjectCreationList.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/ObjectCreationList.cpp index d2b6940f11e..b2eddfdab38 100644 --- a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/ObjectCreationList.cpp +++ b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/ObjectCreationList.cpp @@ -1439,12 +1439,11 @@ class GenericObjectCreationNugget : public ObjectCreationNugget static void parseDebrisObjectNames( INI* ini, void *instance, void *store, const void* /*userData*/ ) { GenericObjectCreationNugget* debrisNugget = (GenericObjectCreationNugget*)instance; - for (const char* debrisName = ini->getNextToken(); debrisName; debrisName = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token; token = ini->getNextTokenOrNull()) { if (TheGlobalData->m_preloadAssets) - debrisModelNamesGlobalHack.push_back(debrisName); - debrisNugget->m_names.push_back(AsciiString(debrisName)); - debrisName = ini->getNextTokenOrNull(); + debrisModelNamesGlobalHack.push_back(token); + debrisNugget->m_names.push_back(AsciiString(token)); } } diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate.cpp index 76c94b122c3..39091729d23 100644 --- a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate.cpp +++ b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate.cpp @@ -177,16 +177,16 @@ const LocomotorTemplateVector* AIUpdateModuleData::findLocomotorTemplateVector(L } self->m_locomotorTemplates[set].clear(); - for (const char* locoName = ini->getNextToken(); locoName; locoName = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token; token = ini->getNextTokenOrNull()) { - if (!*locoName || stricmp(locoName, "None") == 0) + if (!*token || stricmp(token, "None") == 0) continue; - NameKeyType locoKey = NAMEKEY(locoName); + NameKeyType locoKey = NAMEKEY(token); const LocomotorTemplate* lt = TheLocomotorStore->findLocomotorTemplate(locoKey); if (!lt) { - DEBUG_CRASH(("Locomotor %s not found!",locoName)); + DEBUG_CRASH(("Locomotor %s not found!",token)); throw INI_INVALID_DATA; } self->m_locomotorTemplates[set].push_back(lt); diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/StructureCollapseUpdate.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/StructureCollapseUpdate.cpp index 23e88ebcaf7..f5646739cb2 100644 --- a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/StructureCollapseUpdate.cpp +++ b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/StructureCollapseUpdate.cpp @@ -84,7 +84,7 @@ static void parseFX( INI* ini, void *instance, void * /*store*/, const void* /*u { StructureCollapseUpdateModuleData* self = (StructureCollapseUpdateModuleData*)instance; StructureCollapsePhaseType scphase = (StructureCollapsePhaseType)INI::scanIndexList(ini->getNextToken(), TheStructureCollapsePhaseNames); - for (const char* token = ini->getNextToken(); token != nullptr; token = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token != nullptr; token = ini->getNextTokenOrNull()) { const FXList *fxl = TheFXListStore->findFXList((token)); // could be null! this is OK! self->m_fxs[scphase].push_back(fxl); @@ -96,7 +96,7 @@ static void parseOCL( INI* ini, void *instance, void * /*store*/, const void* /* { StructureCollapseUpdateModuleData* self = (StructureCollapseUpdateModuleData*)instance; StructureCollapsePhaseType stphase = (StructureCollapsePhaseType)INI::scanIndexList(ini->getNextToken(), TheStructureCollapsePhaseNames); - for (const char* token = ini->getNextToken(); token != nullptr; token = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token != nullptr; token = ini->getNextTokenOrNull()) { const ObjectCreationList *ocl = TheObjectCreationListStore->findObjectCreationList(token); // could be null! this is OK! self->m_ocls[stphase].push_back(ocl); diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/StructureToppleUpdate.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/StructureToppleUpdate.cpp index 600a6f0ccf4..4dcbe4228eb 100644 --- a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/StructureToppleUpdate.cpp +++ b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/StructureToppleUpdate.cpp @@ -83,7 +83,7 @@ static void parseOCL( INI* ini, void *instance, void * /*store*/, const void* /* { StructureToppleUpdateModuleData* self = (StructureToppleUpdateModuleData*)instance; StructureTopplePhaseType stphase = (StructureTopplePhaseType)INI::scanIndexList(ini->getNextToken(), TheStructureTopplePhaseNames); - for (const char* token = ini->getNextToken(); token != nullptr; token = ini->getNextTokenOrNull()) + for (const char* token = ini->getNextTokenOrNull(); token != nullptr; token = ini->getNextTokenOrNull()) { const ObjectCreationList *ocl = TheObjectCreationListStore->findObjectCreationList(token); // could be null! this is OK! self->m_ocls[stphase].push_back(ocl);