Fix issue575 "Nested generics seem to have issues with support." #577

abing22333 · 2023-08-21T15:06:33Z

abing22333
Aug 21, 2023

Bug Cause

The issue in issue575 is:

The underlying cause is that QDox fails to parse the generics of method return values in interfaces.

However, smart-doc provides support for the JPA Page interface, but the code in ParamsBuildHelper was modified, not JsonBuildHelper. Only the generated JSON data is correct.

Test Case

The test case is in JpaController.

Response-fields:

<body>
<!--StartFragment-->

content | array | No comments found. | -
-- | -- | -- | --
└─any object | object | any object. | -

<!--EndFragment-->
</body>
</html>

Response-example:

 "content": [
    {
      "roleId": 0,
      "roleName": "",
      "age": 0
    }
  ]

JsonBuildHelper Code

ParamsBuildHelper Code

Commit History

8b1aa8b

Questions

I cannot understand the scenario of commit 8b1aa8b, and after reviewing the change logs from May and June 22, there is no relevant information.

Can we directly revert this commit?

Answered by shalousun

Oct 19, 2023

fix by #587

View full answer

abing22333 · 2023-08-21T15:07:29Z

abing22333
Aug 21, 2023
Author

@chenqi146 麻烦有空时解答一下

5 replies

abing22333 Aug 23, 2023
Author

issues 575 的问题是没有加载到源码，导致QDox解析不到泛型。但是ParamsBuildHelper和 JsonBuildHelper中这两处的代码不一致，不会有问题吗？

shalousun Aug 24, 2023

等我我有时间我来看下

shalousun Aug 28, 2023

2.7.3开始smart-doc新增了JavaClassUtil.getFieldGenericType通过反射处理对象的范型字段。但是遗漏了对接口中范型方法的处理。因此可以新增一个处理范型方法的补偿。测试代码如下：

 public static void main(String[] args) {
        try {
            Class c = Class.forName("org.springframework.data.domain.Slice");
            Method[] methods = c.getDeclaredMethods();
            // c.getDeclaredMethod() 修改smart-doc时可以通过这个获取到方法名直接翻着
            for (Method m:methods) {
                
                System.out.println("methodName:"+m.getName());
                System.out.println("modifiers:"+m.getModifiers());
                //获取到范型的方法名
                Type t = m.getGenericReturnType();
                System.out.println("method type:"+t.getTypeName());
            }
        } catch (ClassNotFoundException e) {
           e.fillInStackTrace();
        }
}

通过上面这个测试代码参考JavaClassUtil.getFieldGenericType补充对接口方法的获取即可

chenqi146 Oct 18, 2023

抱歉, 现在才看到消息, 无太大印象了, 我查一下我代码

chenqi146 Oct 18, 2023

@abing22333

在2.4.5版本下

fieldGicName字段不携带泛型, 值为"java.util.List"
此行代码会被覆盖到, 主要解决未读取到源码情况下, object被替换成上一层对象展示出来, 修改后调整为显示any object

而在当前2.7.8版本下

fieldGicName字段值变化了, 携带泛型信息了, 值为"java.util.List"
此行代码回退到之前版本

shalousun · 2023-10-19T03:45:27Z

shalousun
Oct 19, 2023

fix by #587

0 replies

Uh oh!

Fix issue575 "Nested generics seem to have issues with support." #577

Uh oh!

Uh oh!

abing22333 Aug 21, 2023

Bug Cause

Test Case

Response-fields:

Response-example:

JsonBuildHelper Code

ParamsBuildHelper Code

Commit History

Questions

Replies: 2 comments · 5 replies

Uh oh!

abing22333 Aug 21, 2023 Author

Uh oh!

Uh oh!

abing22333 Aug 23, 2023 Author

Uh oh!

shalousun Aug 24, 2023

Uh oh!

Uh oh!

shalousun Aug 28, 2023

Uh oh!

chenqi146 Oct 18, 2023

Uh oh!

Uh oh!

chenqi146 Oct 18, 2023

在2.4.5版本下

而在当前2.7.8版本下

Uh oh!

shalousun Oct 19, 2023

abing22333
Aug 21, 2023

Replies: 2 comments 5 replies

abing22333
Aug 21, 2023
Author

abing22333 Aug 23, 2023
Author

shalousun
Oct 19, 2023