Manually list tets files as is recommended for using CMake

Author: connoraird

episodes/3-writing-your-first-unit-test/challenge/README.md

@@ -22,7 +22,7 @@ know that there is no function which does this direct conversion. With this is m
 a test, or tests, to give you confidence that temp_conversions can correctly convert
 Fahrenheit to Kelvin.
 
-To get you started, the file [test_temp_conversions.f90](./test/test_temp_conversions.f90)
+To get you started, the file [test_temp_conversions.f90](./test/standard_fortran/test_temp_conversions.f90)
 has been provided. `test_temp_conversions.f90` contains some boilerplate to make writing a
 test easier. There is an empty test subroutine `test` provided which takes in a logical
 `passed` and a character array `failure_message`. The logical `passed` should indicate if
@@ -31,6 +31,9 @@ message that will be printed to the terminal in the event that `passed` is `.fal
 the test subroutine is written it should be called within the main body of the test program
 as indicated in `test_temp_conversions.f90`.
 
+> Not: If you add a new test file or change the name of `test_temp_conversions.f90`, you will
+> need to update list of tests (`test_src`) in [test/pfunit/CMakeLists.txt](./test/pfunit/CMakeLists.txt)
+
 ### Part 2 - Convert tests to use pFUnit
 
 Convert your tests from [Part 1](#part-1---test-with-standard-fortran), to use
@@ -41,7 +44,7 @@ for your pFUnit test(s) has been provided. Comments within this file indicate th
 the pFUnit test you must write.
 
 > Note: This template has been written to facilitate conversion of
-> [test_temp_conversions.f90](./test/test_temp_conversions.f90) as provided with this repo
+> [test_temp_conversions.f90](./test/standard_fortran/test_temp_conversions.f90) as provided with this repo
 > to pFUnit. If your version of test_temp_conversions.f90, produced in Part 1, is significantly
 > different, You may prefer to use a different structure to the one provided in the template.
 
@@ -54,4 +57,7 @@ cmake --build build
 ctest --test-dir build --output-on-failure
 ```
 
+If your test does not get built, ensure you have added it to the list of tests (`test_src`)
+in [test/pfunit/CMakeLists.txt](./test/pfunit/CMakeLists.txt)
+
 > If you are using the devcontainer, there is an installation of pFUnit at /home/vscode/pfunit/build/installed

episodes/3-writing-your-first-unit-test/challenge/test/CMakeLists.txt

@@ -1,7 +1,7 @@
 find_package(PFUNIT QUIET)
 
+add_subdirectory("standard_fortran")
+
 if (PFUNIT_FOUND)
     add_subdirectory("pfunit")
-else()
-    add_subdirectory("standard_fortran")
 endif()

episodes/3-writing-your-first-unit-test/challenge/test/pfunit/.gitignore

@@ -1 +1,2 @@
 *.f90
+*.F90

episodes/3-writing-your-first-unit-test/challenge/test/pfunit/CMakeLists.txt

@@ -6,15 +6,7 @@ set(TEST_DIR "${PROJECT_SOURCE_DIR}/test/pfunit")
 add_library (sut STATIC ${PROJ_SRC_FILES})
 
 # List all test files
-file(GLOB
-    test_srcs
-    "${TEST_DIR}/*.pf"
-)
-
-list(LENGTH test_srcs num_test_srcs)
-if (num_test_srcs EQUAL 0)
-    message(FATAL_ERROR "No .pf files found in: ${TEST_DIR}")
-endif()
+set(test_srcs "test_temp_conversions.pf")
 
 add_pfunit_ctest (pfunit_test_temp_conversions_exec
     TEST_SOURCES ${test_srcs}

episodes/3-writing-your-first-unit-test/challenge/test/standard_fortran/CMakeLists.txt

@@ -3,12 +3,7 @@ message(STATUS "Using standard Fortran")
 set(TEST_DIR "${PROJECT_SOURCE_DIR}/test/standard_fortran")
 
 # Define test file(s)
-file(GLOB test_srcs "${TEST_DIR}/*.f90")
-
-list(LENGTH test_srcs num_test_srcs)
-if (num_test_srcs EQUAL 0)
-    message(FATAL_ERROR "No .f90 files found in: ${TEST_DIR}")
-endif()
+set(test_srcs "test_temp_conversions.f90")
 
 # Build test executable
 add_executable(test_temp_conversions_exec

episodes/3-writing-your-first-unit-test/solution/README.md

@@ -23,7 +23,7 @@ investigation would be required.
 
 #### Parameterised tests
 
-Each test subroutine in [test_temp_conversions.f90](./test_temp_conversions.f90) take in an `input` and an `expected_output`.
+Each test subroutine in [test_temp_conversions.f90](./test_temp_conversions.f90) takes in an `input` and an `expected_output`.
 This allows the same test subroutine to be called with multiple different inputs to test several scenarios with the same test
 code. Therefore, we are able to test edge cases and other key scenarios more easily.
 

episodes/3-writing-your-first-unit-test/solution/test_temp_conversions.pf

@@ -108,6 +108,7 @@ contains
         type(temp_conversions_test_params_t), intent(in) :: testParameter
         !> The test case to return after conversion from parameters
         type(temp_conversions_test_case_t) :: tst
+
         tst%params = testParameter
     end function new_test_case
 
@@ -116,6 +117,7 @@ contains
         !> The parameters to be converted to a string
         class(temp_conversions_test_params_t), intent(in) :: this
         character(:), allocatable :: string
+
         string = trim(this%description)
     end function temp_conversions_test_params_t_toString