Skip to content

Better test coverage for ERC6909 code path #428

Description

@zhongeric

Component

Tests

Describe the suggested feature and problem it solves.

Right now we pass a parameter TestSettings into PoolManager tests to determine whether or not the we call take/settle or mint/burn during a swap. There are only two tests currently in PoolManager.t.sol which check the results of the mint/burn code path.

Describe the desired implementation.

Explore fuzzing of the TestSettings with conditional assertions or potentially remove the TestSettings logic and split out the PoolSwapRouter into PoolERC6909Router and PoolERC20Router, each of which inherit from PoolTestBase

Describe alternatives.

No response

Additional context.

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions