Skip to content

The theme recommendation button promises the wrong changes #587

Description

@nickhamze

The Themes action says Apply recommended layout and effects, but themes are free to recommend a different set of preferences.

During the audit, the Legacy theme changed only the accent. OpenStation changed the accent, layout, and dock position. Neither action changed the window or reveal effects promised by the label.

That makes the button hard to trust: it can change things it does not name and leave named things untouched.

How to reproduce

  1. Select the Legacy theme.
  2. Set a distinctive accent, layout, and effect combination.
  3. Use the recommendation action and compare the values.
  4. Repeat with the OpenStation theme.

Suggested wording

Use a truthful generic label such as Apply recommended preferences, or build a confirmation from the actual keys in the theme manifest.

PR #581 changes the button to Apply recommended preferences and updates the surrounding explanation.

The recommendation action is labeled as layout and effects

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions