diff --git a/.github/workflows/docker-hub.yml b/.github/workflows/docker-hub.yml index 05b4dd0..4cdb78f 100644 --- a/.github/workflows/docker-hub.yml +++ b/.github/workflows/docker-hub.yml @@ -22,9 +22,6 @@ on: - cron: '0 0 * * 0' env: - REGISTRY_USERNAME: garypendergast - REGISTRY_PASSWORD: ${{ secrets.DOCKER_PASSWORD }} - PACKAGE_REGISTRY_HOST: PACKAGE_REGISTRY: wordpressdevelop PR_TAG: @@ -46,6 +43,7 @@ jobs: name: PHP ${{ matrix.php }} Image runs-on: ubuntu-latest + environment: 'Docker Hub' strategy: matrix: php: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5' ] @@ -53,6 +51,7 @@ jobs: env: PHP_VERSION: ${{ matrix.php }} PHP_LATEST: '8.3' + REGISTRY_USERNAME: ${{ vars.REGISTRY_USERNAME }} permissions: contents: read @@ -63,13 +62,14 @@ jobs: persist-credentials: false - name: Login to the package registry - run: | - echo "$REGISTRY_PASSWORD" | docker login "$PACKAGE_REGISTRY_HOST" -u "$REGISTRY_USERNAME" --password-stdin + uses: docker/login-action@4907a6ddec9925e35a0a9e82d7399ccc52663121 # v4.1.0 + with: + username: ${{ env.REGISTRY_USERNAME }} + password: ${{ secrets.REGISTRY_PASSWORD }} - name: Build Docker image run: | docker build \ - --build-arg PACKAGE_REGISTRY="$PACKAGE_REGISTRY" \ --build-arg PR_TAG="$PR_TAG" \ -t "$PACKAGE_REGISTRY/php:$PHP_VERSION-fpm$PR_TAG" \ "images/$PHP_VERSION/php" @@ -91,6 +91,7 @@ jobs: name: CLI on PHP ${{ matrix.php }} runs-on: ubuntu-latest needs: build-php-images + environment: 'Docker Hub' strategy: matrix: php: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5' ] @@ -101,7 +102,7 @@ jobs: env: PHP_VERSION: ${{ matrix.php }} PHP_LATEST: '8.3' - + REGISTRY_USERNAME: ${{ vars.REGISTRY_USERNAME }} steps: - name: Checkout repository uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 @@ -109,8 +110,10 @@ jobs: persist-credentials: false - name: Login to the package registry - run: | - echo "$REGISTRY_PASSWORD" | docker login "$PACKAGE_REGISTRY_HOST" -u "$REGISTRY_USERNAME" --password-stdin + uses: docker/login-action@4907a6ddec9925e35a0a9e82d7399ccc52663121 # v4.1.0 + with: + username: ${{ env.REGISTRY_USERNAME }} + password: ${{ secrets.REGISTRY_PASSWORD }} - name: Build Docker image run: | diff --git a/.github/workflows/github-container-registry.yml b/.github/workflows/github-container-registry.yml index d8c6899..05d5c5b 100644 --- a/.github/workflows/github-container-registry.yml +++ b/.github/workflows/github-container-registry.yml @@ -13,9 +13,6 @@ on: workflow_dispatch: env: - REGISTRY_USERNAME: desrosj - REGISTRY_PASSWORD: ${{ secrets.GHCR_TOKEN }} - PACKAGE_REGISTRY_HOST: ghcr.io PACKAGE_REGISTRY: ghcr.io/wordpress/wpdev-docker-images PR_TAG: -${{ github.event.number }} @@ -59,6 +56,7 @@ jobs: name: PHP ${{ matrix.php }} Image runs-on: ubuntu-latest needs: [ check-for-changes ] + environment: 'GitHub Container Registry' strategy: matrix: php: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5' ] @@ -66,6 +64,7 @@ jobs: env: PHP_VERSION: ${{ matrix.php }} PHP_LATEST: '8.3' + REGISTRY_USERNAME: ${{ vars.REGISTRY_USERNAME }} permissions: contents: read @@ -76,13 +75,15 @@ jobs: persist-credentials: false - name: Login to the package registry - run: | - echo "$REGISTRY_PASSWORD" | docker login "$PACKAGE_REGISTRY_HOST" -u "$REGISTRY_USERNAME" --password-stdin + uses: docker/login-action@4907a6ddec9925e35a0a9e82d7399ccc52663121 # v4.1.0 + with: + registry: ghcr.io + username: ${{ env.REGISTRY_USERNAME }} + password: ${{ secrets.REGISTRY_PASSWORD }} - name: Build Docker image run: | docker build \ - --build-arg PACKAGE_REGISTRY="$PACKAGE_REGISTRY" \ --build-arg PR_TAG="$PR_TAG" \ -t "$PACKAGE_REGISTRY/php:$PHP_VERSION-fpm$PR_TAG" \ "images/$PHP_VERSION/php" @@ -104,6 +105,7 @@ jobs: name: CLI on PHP ${{ matrix.php }} runs-on: ubuntu-latest needs: build-php-images + environment: 'GitHub Container Registry' strategy: matrix: php: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5' ] @@ -114,7 +116,7 @@ jobs: env: PHP_VERSION: ${{ matrix.php }} PHP_LATEST: '8.3' - + REGISTRY_USERNAME: ${{ vars.REGISTRY_USERNAME }} steps: - name: Checkout repository uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 @@ -122,8 +124,11 @@ jobs: persist-credentials: false - name: Login to the package registry - run: | - echo "$REGISTRY_PASSWORD" | docker login "$PACKAGE_REGISTRY_HOST" -u "$REGISTRY_USERNAME" --password-stdin + uses: docker/login-action@4907a6ddec9925e35a0a9e82d7399ccc52663121 # v4.1.0 + with: + registry: ghcr.io + username: ${{ env.REGISTRY_USERNAME }} + password: ${{ secrets.REGISTRY_PASSWORD }} - name: Build Docker image run: | diff --git a/templates/workflow.yml-template b/templates/workflow.yml-template index 91b1870..421e6b4 100644 --- a/templates/workflow.yml-template +++ b/templates/workflow.yml-template @@ -17,9 +17,6 @@ on: - cron: '0 0 * * 0' env: - REGISTRY_USERNAME: garypendergast - REGISTRY_PASSWORD: ${{ secrets.DOCKER_PASSWORD }} - PACKAGE_REGISTRY_HOST: PACKAGE_REGISTRY: wordpressdevelop PR_TAG: %%/DOCKER_HUB%% @@ -31,9 +28,6 @@ on: workflow_dispatch: env: - REGISTRY_USERNAME: desrosj - REGISTRY_PASSWORD: ${{ secrets.GHCR_TOKEN }} - PACKAGE_REGISTRY_HOST: ghcr.io PACKAGE_REGISTRY: ghcr.io/wordpress/wpdev-docker-images PR_TAG: -${{ github.event.number }} %%/GITHUB%% @@ -77,6 +71,7 @@ jobs: name: PHP ${{ matrix.php }} Image runs-on: ubuntu-latest %%GITHUB%%needs: [ check-for-changes ]%%/GITHUB%% + environment: '%%GITHUB%%GitHub Container Registry%%/GITHUB%%%%DOCKER_HUB%%Docker Hub%%/DOCKER_HUB%%' strategy: matrix: php: [ %%PHP_VERSION_LIST%% ] @@ -84,6 +79,7 @@ jobs: env: PHP_VERSION: ${{ matrix.php }} PHP_LATEST: '%%PHP_LATEST%%' + REGISTRY_USERNAME: ${{ vars.REGISTRY_USERNAME }} permissions: contents: read @@ -94,13 +90,15 @@ jobs: persist-credentials: false - name: Login to the package registry - run: | - echo "$REGISTRY_PASSWORD" | docker login "$PACKAGE_REGISTRY_HOST" -u "$REGISTRY_USERNAME" --password-stdin + uses: docker/login-action@4907a6ddec9925e35a0a9e82d7399ccc52663121 # v4.1.0 + with:%%GITHUB%% + registry: ghcr.io%%/GITHUB%% + username: ${{ env.REGISTRY_USERNAME }} + password: ${{ secrets.REGISTRY_PASSWORD }} - name: Build Docker image run: | docker build \ - --build-arg PACKAGE_REGISTRY="$PACKAGE_REGISTRY" \ --build-arg PR_TAG="$PR_TAG" \ -t "$PACKAGE_REGISTRY/php:$PHP_VERSION-fpm$PR_TAG" \ "images/$PHP_VERSION/php" @@ -122,6 +120,7 @@ jobs: name: CLI on PHP ${{ matrix.php }} runs-on: ubuntu-latest needs: build-php-images + environment: '%%GITHUB%%GitHub Container Registry%%/GITHUB%%%%DOCKER_HUB%%Docker Hub%%/DOCKER_HUB%%' strategy: matrix: php: [ %%PHP_VERSION_LIST%% ] @@ -132,7 +131,7 @@ jobs: env: PHP_VERSION: ${{ matrix.php }} PHP_LATEST: '%%PHP_LATEST%%' - + REGISTRY_USERNAME: ${{ vars.REGISTRY_USERNAME }} steps: - name: Checkout repository uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 @@ -140,8 +139,11 @@ jobs: persist-credentials: false - name: Login to the package registry - run: | - echo "$REGISTRY_PASSWORD" | docker login "$PACKAGE_REGISTRY_HOST" -u "$REGISTRY_USERNAME" --password-stdin + uses: docker/login-action@4907a6ddec9925e35a0a9e82d7399ccc52663121 # v4.1.0 + with:%%GITHUB%% + registry: ghcr.io%%/GITHUB%% + username: ${{ env.REGISTRY_USERNAME }} + password: ${{ secrets.REGISTRY_PASSWORD }} - name: Build Docker image run: |