fix: update Exoscale DNS script #6675
Open
+132
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome |
Neilpang
reviewed
Dec 8, 2025
dnsapi/dns_exoscale.sh
Outdated
| record_name=$(echo "$record" | _egrep_o '"name":"[^"]*"' | cut -d'"' -f4) | ||
| record_name_lower=$(echo "$record_name" | tr '[:upper:]' '[:lower:]') | ||
| if [ "$record_name_lower" = "$name_lower" ]; then | ||
| echo "$record" | _egrep_o '"id":"[^"]*"' | head -n1 | cut -d'"' -f4 |
Neilpang
reviewed
Dec 8, 2025
dnsapi/dns_exoscale.sh
Outdated
| fi | ||
| # Build the message with the actual body or empty line | ||
| message=$(printf "%s %s\n%s\n\n\n%s" "$method" "/v2$path" "$data" "$expiration") | ||
| signature=$(printf "%s" "$message" | ${ACME_OPENSSL_BIN:-openssl} dgst -sha256 -hmac "$EXOSCALE_SECRET_KEY" -binary | _base64) |
Member
There was a problem hiding this comment.
don't use openssl here, use _hmac()
imiric
force-pushed
the
fix/exoscale-dns
branch
2 times, most recently
from
ea77497 to
b986b65
Compare
This updates the Exoscale DNS script to work with v2 of their API.
imiric
force-pushed
the
fix/exoscale-dns
branch
from
b986b65 to
1413aa3
Compare
pierre-emmanuelJ
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Exoscale DNS script to work with v2 of their API.
I ran the DNS CI workflow in my fork according to the DNS API Dev Guide, and it passed.
The script is very brittle due to parsing JSON with
_egrep_o, so any improvement suggestions would be appreciated.Closes #5165