From 1263a9ec1101cb4532e8032c6f34c497e4b5795d Mon Sep 17 00:00:00 2001 From: holmesworcester Date: Mon, 13 Jan 2020 15:08:54 -0500 Subject: [PATCH] Fixes failure to launch "new user" / "popular" screens post onboard This is a fix for the following issue: https://meta.getaether.net/t/aether-fails-to-show-new-user-modal-after-saying-yes-to-onboarding-question-create-new-user/350 The problem was that a navigation guard was in place preventing navigation outside onboarding screens until onboarding was set to complete in VueX store. This fix ensures that router.push is called only *after* onboarding is successfully set to complete. There is a slight issue with scroll position in the "create new user" screen, where the screen's title is not visible, but it looks alright and feels quite natural at the default window size so I think it's fine. It might be good to make a mixin for resetting the scroll position and use that here just to be sure. --- .../app/components/locations/onboardscope/onboard6.vue | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/aether-core/aether/client/src/app/components/locations/onboardscope/onboard6.vue b/aether-core/aether/client/src/app/components/locations/onboardscope/onboard6.vue index 07654b2..860d5b5 100644 --- a/aether-core/aether/client/src/app/components/locations/onboardscope/onboard6.vue +++ b/aether-core/aether/client/src/app/components/locations/onboardscope/onboard6.vue @@ -30,12 +30,14 @@ export default { }, methods: { toNewUser(this: any) { - this.$router.push('/newuser') - fe.SetOnboardComplete(true, function() {}) + fe.SetOnboardComplete(true, () => { + this.$router.push('/newuser') + }) }, toApp(this: any) { - this.$router.push('/popular') - fe.SetOnboardComplete(true, function() {}) + fe.SetOnboardComplete(true, () => { + this.$router.push('/popular') + }) }, }, }