Update comment, check if code is bool, and use logger instead of print

Signed-off-by: Phillippe Siclait <[email protected]>

Author: siclait

lib/bindings/python/rust/http.rs

@@ -160,8 +160,8 @@ where
                 if let Some(py_err) = e.downcast_ref::<PyErr>() {
                     Python::with_gil(|py| {
                         // With the Stable ABI, we can't subclass Python's built-in exceptions in PyO3, so instead we
-                        // implement the exception in Python and use duck typing / assume that it's an HttpError if
-                        // the code and message are present.
+                        // implement the exception in Python and assume that it's an HttpError if the code and message
+                        // are present.
                         if let Ok(HttpError { code, message }) =
                             py_err.value(py).extract::<HttpError>()
                         {

lib/bindings/python/src/dynamo/llm/exceptions.py

@@ -3,14 +3,18 @@
 
 # flake8: noqa
 
+import logging
+
+logger = logging.getLogger(__name__)
+
 _MAX_MESSAGE_LENGTH = 8192
 
 
 class HttpError(Exception):
     def __init__(self, code: int, message: str):
         # These ValueErrors are easier to trace to here than the TypeErrors that
         # would be raised otherwise.
-        if not isinstance(code, int):
+        if not isinstance(code, int) or isinstance(code, bool):
             raise ValueError("HttpError status code must be an integer")
 
         if not isinstance(message, str):
@@ -20,7 +24,7 @@ def __init__(self, code: int, message: str):
             raise ValueError("HTTP status code must be an integer between 0 and 599")
 
         if len(message) > _MAX_MESSAGE_LENGTH:
-            print(
+            logger.warning(
                 f"HttpError message length {len(message)} exceeds max length {_MAX_MESSAGE_LENGTH}, truncating..."
             )
             message = message[: (_MAX_MESSAGE_LENGTH - 3)] + "..."