From 7483440934aaf6e96f57caeec994bbd2245aece2 Mon Sep 17 00:00:00 2001 From: Sanjaiyan Parthipan Date: Thu, 26 Dec 2024 12:37:57 +0530 Subject: [PATCH 1/2] perf: Improve performance by running async tasks concurrently --- build-system/tasks/dist.js | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/build-system/tasks/dist.js b/build-system/tasks/dist.js index f276e3db3c67..ea34e86cdd7d 100644 --- a/build-system/tasks/dist.js +++ b/build-system/tasks/dist.js @@ -210,17 +210,17 @@ function buildLoginDone(version) { async function buildWebPushPublisherFiles() { const distDir = 'dist/v0'; for (const version of WEB_PUSH_PUBLISHER_VERSIONS) { - for (const fileName of WEB_PUSH_PUBLISHER_FILES) { + await Promise.all(WEB_PUSH_PUBLISHER_FILES.map((fileName) => { const tempBuildDir = `build/all/amp-web-push-${version}`; const builtName = `${fileName}.js`; const minifiedName = maybeToEsmName(builtName); - await compileJs(`./${tempBuildDir}`, builtName, `./${distDir}`, { + return compileJs(`./${tempBuildDir}`, builtName, `./${distDir}`, { watch: argv.watch, includePolyfills: true, minify: true, minifiedName, }); - } + })); } await postBuildWebPushPublisherFilesVersion(); } @@ -284,8 +284,10 @@ async function postBuildWebPushPublisherFilesVersion() { } // Build Helper Frame HTML - const html = await fs.readFile(`${basePath}/${fileName}.html`, 'utf8'); - const js = await fs.readFile(minifiedFile, 'utf8'); + const [html, js] = await Promise.all([ + fs.readFile(`${basePath}/${fileName}.html`, 'utf8'), + fs.readFile(minifiedFile, 'utf8') + ]); const minifiedHtml = html.replace( ``, `` From b6b250e9b749bf8df6dbf529f0f4af6b8aeccb78 Mon Sep 17 00:00:00 2001 From: Sanjaiyan Parthipan Date: Thu, 3 Sep 2026 21:31:39 +0530 Subject: [PATCH 2/2] build: Refactor buildWebPushPublisherFiles for improved readability --- build-system/tasks/dist.js | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/build-system/tasks/dist.js b/build-system/tasks/dist.js index ea34e86cdd7d..4443af80f0e3 100644 --- a/build-system/tasks/dist.js +++ b/build-system/tasks/dist.js @@ -210,17 +210,19 @@ function buildLoginDone(version) { async function buildWebPushPublisherFiles() { const distDir = 'dist/v0'; for (const version of WEB_PUSH_PUBLISHER_VERSIONS) { - await Promise.all(WEB_PUSH_PUBLISHER_FILES.map((fileName) => { - const tempBuildDir = `build/all/amp-web-push-${version}`; - const builtName = `${fileName}.js`; - const minifiedName = maybeToEsmName(builtName); - return compileJs(`./${tempBuildDir}`, builtName, `./${distDir}`, { - watch: argv.watch, - includePolyfills: true, - minify: true, - minifiedName, - }); - })); + await Promise.all( + WEB_PUSH_PUBLISHER_FILES.map((fileName) => { + const tempBuildDir = `build/all/amp-web-push-${version}`; + const builtName = `${fileName}.js`; + const minifiedName = maybeToEsmName(builtName); + return compileJs(`./${tempBuildDir}`, builtName, `./${distDir}`, { + watch: argv.watch, + includePolyfills: true, + minify: true, + minifiedName, + }); + }) + ); } await postBuildWebPushPublisherFilesVersion(); } @@ -286,7 +288,7 @@ async function postBuildWebPushPublisherFilesVersion() { // Build Helper Frame HTML const [html, js] = await Promise.all([ fs.readFile(`${basePath}/${fileName}.html`, 'utf8'), - fs.readFile(minifiedFile, 'utf8') + fs.readFile(minifiedFile, 'utf8'), ]); const minifiedHtml = html.replace( ``,