Search before asking
What would you like to be improved?
The mixed-hive test suite already covers several rewrite and overwrite scenarios, but multiple test methods still contain the same TODO: add cases for tables without partition spec.
Examples can be found in:
amoro-format-mixed/amoro-mixed-hive/src/test/java/org/apache/amoro/hive/op/TestRewriteFiles.java
amoro-format-mixed/amoro-mixed-hive/src/test/java/org/apache/amoro/hive/op/TestOverwriteFiles.java
Currently these cases are guarded by Assume.assumeTrue(isPartitionedTable()), so behavior for non-partitioned tables is not covered well enough.
How should we improve?
We should add non-partitioned table test coverage for mixed-hive rewrite and overwrite operations.
A contributor can start by:
- identifying the existing partitioned-only test cases in
TestRewriteFiles and TestOverwriteFiles
- adding equivalent or adapted cases for tables without partition spec
- verifying whether non-partitioned tables should succeed or throw the expected exception in each scenario
- keeping the new tests independent and easy to understand
Are you willing to submit PR?
Subtasks
Code of Conduct
Search before asking
What would you like to be improved?
The mixed-hive test suite already covers several rewrite and overwrite scenarios, but multiple test methods still contain the same TODO: add cases for tables without partition spec.
Examples can be found in:
amoro-format-mixed/amoro-mixed-hive/src/test/java/org/apache/amoro/hive/op/TestRewriteFiles.javaamoro-format-mixed/amoro-mixed-hive/src/test/java/org/apache/amoro/hive/op/TestOverwriteFiles.javaCurrently these cases are guarded by
Assume.assumeTrue(isPartitionedTable()), so behavior for non-partitioned tables is not covered well enough.How should we improve?
We should add non-partitioned table test coverage for mixed-hive rewrite and overwrite operations.
A contributor can start by:
TestRewriteFilesandTestOverwriteFilesAre you willing to submit PR?
Subtasks
TestRewriteFilesTestOverwriteFilesCode of Conduct