This now does full validation for LIstViewArray I think -- which is more expensive than the previous creation via data.build_unchecked()
I can see two alternatives:
- Add a
unsafe GenericListViewArray::new_unchecked methods
- Leave this code as is and create an ArrayRef directly from the ArrayData
I would selfishly suggest 2 (and then a follow on PR to add unsafe GenericListViewArray::new_unchecked / rework this code) to make reviewing this one eaiser on my
Originally posted by @alamb in #9497 (comment)
This now does full validation for LIstViewArray I think -- which is more expensive than the previous creation via data.build_unchecked()
I can see two alternatives:
unsafe GenericListViewArray::new_uncheckedmethodsI would selfishly suggest 2 (and then a follow on PR to add
unsafe GenericListViewArray::new_unchecked/ rework this code) to make reviewing this one eaiser on myOriginally posted by @alamb in #9497 (comment)