Skip to content

Support GenericListViewArray::new_unchecked and refactor ListView json decoder #9646

@liamzwbao

Description

@liamzwbao

This now does full validation for LIstViewArray I think -- which is more expensive than the previous creation via data.build_unchecked()

I can see two alternatives:

  1. Add a unsafe GenericListViewArray::new_unchecked methods
  2. Leave this code as is and create an ArrayRef directly from the ArrayData

I would selfishly suggest 2 (and then a follow on PR to add unsafe GenericListViewArray::new_unchecked / rework this code) to make reviewing this one eaiser on my

Originally posted by @alamb in #9497 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions