Repository navigation
Commit 03065ec
committed
chore(ci): Register the substrait check job with runs-on, route spark checks through xtask
Two small inconsistencies in the `cargo check <crate> features` jobs.
`cargo check datafusion-substrait features` selects a `runs-on` runner with
`extras=s3-cache`, but is the only one of the fifteen jobs that select such a
runner without the `runs-on/action` step that registers it. Without that step
the job gets neither the external cache nor the job metrics the other fourteen
report.
`cargo check datafusion-spark features` is the last place in the workflow that
calls `cargo check` directly rather than going through `cargo xtask ci step
check`, so those three checks cannot be reproduced locally the way every other
check step can.
The three commands xtask emits are identical to the ones being replaced:
default -> cargo check --profile ci --all-targets -p datafusion-spark
no-default -> cargo check --profile ci --no-default-features -p datafusion-spark
core -> cargo check --profile ci --no-default-features -p datafusion-spark --features core
Job names are unchanged, so the required checks in `.asf.yaml` are unaffected.1 parent edc936f commit 03065ec
1 file changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
| 162 | + | |
162 | 163 | | |
163 | 164 | | |
164 | 165 | | |
| |||
399 | 400 | | |
400 | 401 | | |
401 | 402 | | |
402 | | - | |
| 403 | + | |
403 | 404 | | |
404 | 405 | | |
405 | 406 | | |
406 | 407 | | |
407 | | - | |
| 408 | + | |
408 | 409 | | |
409 | | - | |
| 410 | + | |
410 | 411 | | |
411 | 412 | | |
412 | 413 | | |
| |||
0 commit comments