Skip to content

Commit 03065ec

Browse files
chore(ci): Register the substrait check job with runs-on, route spark checks through xtask
Two small inconsistencies in the `cargo check <crate> features` jobs. `cargo check datafusion-substrait features` selects a `runs-on` runner with `extras=s3-cache`, but is the only one of the fifteen jobs that select such a runner without the `runs-on/action` step that registers it. Without that step the job gets neither the external cache nor the job metrics the other fourteen report. `cargo check datafusion-spark features` is the last place in the workflow that calls `cargo check` directly rather than going through `cargo xtask ci step check`, so those three checks cannot be reproduced locally the way every other check step can. The three commands xtask emits are identical to the ones being replaced: default -> cargo check --profile ci --all-targets -p datafusion-spark no-default -> cargo check --profile ci --no-default-features -p datafusion-spark core -> cargo check --profile ci --no-default-features -p datafusion-spark --features core Job names are unchanged, so the required checks in `.asf.yaml` are unaffected.
1 parent edc936f commit 03065ec

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

‎.github/workflows/rust.yml‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,7 @@ jobs:
159159
container:
160160
image: amd64/rust
161161
steps:
162+
- uses: runs-on/action@efac073ea2507ec18797de3a81704201ade11d9d # v2.3.1
162163
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
163164
- name: Setup Rust toolchain
164165
uses: ./.github/actions/setup-builder
@@ -399,14 +400,14 @@ jobs:
399400
save-if: false # The workspace and functions checks save this cache on main.
400401
shared-key: "amd-ci-check"
401402
- name: Check datafusion-spark (default features)
402-
run: cargo check --profile ci --all-targets -p datafusion-spark
403+
run: cargo xtask ci step check datafusion-spark default
403404
#
404405
# Note: Only check libraries (not --all-targets) to cover end user APIs
405406
#
406407
- name: Check datafusion-spark (no-default-features)
407-
run: cargo check --profile ci --no-default-features -p datafusion-spark
408+
run: cargo xtask ci step check datafusion-spark no-default
408409
- name: Check datafusion-spark (core)
409-
run: cargo check --profile ci --no-default-features -p datafusion-spark --features=core
410+
run: cargo xtask ci step check datafusion-spark core
410411

411412
# Library and integration tests
412413
linux-test:

0 commit comments

Comments
 (0)