Skip to content

Commit 2b0cfd9

Browse files
chore(ci): Register the substrait check job with runs-on, route spark checks through xtask
Two small inconsistencies in the `cargo check <crate> features` jobs. `cargo check datafusion-substrait features` selects a `runs-on` runner with `extras=s3-cache`, but is the only one of the fifteen jobs that select such a runner without the `runs-on/action` step that registers it. Without that step the job gets neither the external cache nor the job metrics the other fourteen report. `cargo check datafusion-spark features` is the last place in the workflow that calls `cargo check` directly rather than going through `cargo xtask ci step check`, so those three checks cannot be reproduced locally the way every other check step can. The three commands xtask emits are identical to the ones being replaced: default -> cargo check --profile ci --all-targets -p datafusion-spark no-default -> cargo check --profile ci --no-default-features -p datafusion-spark core -> cargo check --profile ci --no-default-features -p datafusion-spark --features core Job names are unchanged, so the required checks in `.asf.yaml` are unaffected.
1 parent f8cc678 commit 2b0cfd9

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

‎.github/workflows/rust.yml‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ jobs:
115115
container:
116116
image: amd64/rust
117117
steps:
118+
- uses: runs-on/action@efac073ea2507ec18797de3a81704201ade11d9d # v2.3.1
118119
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
119120
- name: Setup Rust toolchain
120121
uses: ./.github/actions/setup-builder
@@ -315,14 +316,14 @@ jobs:
315316
with:
316317
rust-version: stable
317318
- name: Check datafusion-spark (default features)
318-
run: cargo check --profile ci --all-targets -p datafusion-spark
319+
run: cargo xtask ci step check datafusion-spark default
319320
#
320321
# Note: Only check libraries (not --all-targets) to cover end user APIs
321322
#
322323
- name: Check datafusion-spark (no-default-features)
323-
run: cargo check --profile ci --no-default-features -p datafusion-spark
324+
run: cargo xtask ci step check datafusion-spark no-default
324325
- name: Check datafusion-spark (core)
325-
run: cargo check --profile ci --no-default-features -p datafusion-spark --features=core
326+
run: cargo xtask ci step check datafusion-spark core
326327

327328
# Library and integration tests
328329
linux-test:

0 commit comments

Comments
 (0)