Repository navigation
Commit 2b0cfd9
committed
chore(ci): Register the substrait check job with runs-on, route spark checks through xtask
Two small inconsistencies in the `cargo check <crate> features` jobs.
`cargo check datafusion-substrait features` selects a `runs-on` runner with
`extras=s3-cache`, but is the only one of the fifteen jobs that select such a
runner without the `runs-on/action` step that registers it. Without that step
the job gets neither the external cache nor the job metrics the other fourteen
report.
`cargo check datafusion-spark features` is the last place in the workflow that
calls `cargo check` directly rather than going through `cargo xtask ci step
check`, so those three checks cannot be reproduced locally the way every other
check step can.
The three commands xtask emits are identical to the ones being replaced:
default -> cargo check --profile ci --all-targets -p datafusion-spark
no-default -> cargo check --profile ci --no-default-features -p datafusion-spark
core -> cargo check --profile ci --no-default-features -p datafusion-spark --features core
Job names are unchanged, so the required checks in `.asf.yaml` are unaffected.1 parent f8cc678 commit 2b0cfd9
1 file changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
| 118 | + | |
118 | 119 | | |
119 | 120 | | |
120 | 121 | | |
| |||
315 | 316 | | |
316 | 317 | | |
317 | 318 | | |
318 | | - | |
| 319 | + | |
319 | 320 | | |
320 | 321 | | |
321 | 322 | | |
322 | 323 | | |
323 | | - | |
| 324 | + | |
324 | 325 | | |
325 | | - | |
| 326 | + | |
326 | 327 | | |
327 | 328 | | |
328 | 329 | | |
| |||
0 commit comments