Repository navigation
Conversation
github-actions
Bot
added
sqllogictest
Contributor
Author
|
@neilconway addressing #26205 (review) |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #26209 +/- ##
=======================================
Coverage 82.80% 82.80%
=======================================
Files 1149 1149
Lines 452213 452281 +68
Branches 452213 452281 +68
=======================================
+ Hits 374473 374531 +58
+ Misses 54945 54942 -3
- Partials 22795 22808 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@Jefffrey any chance you have a sec to review this one please? |
Jefffrey
reviewed
Oct 14, 2026
| .collect::<Vec<_>>(); | ||
| Ok(Field::new( | ||
| self.name(), | ||
| self.return_type(&arg_types)?, |
Contributor
There was a problem hiding this comment.
Suggested change
| self.return_type(&arg_types)?, | |
| deduce_return_type(&arg_types)?, |
then can leave return_type to return a not implemented error, same pattern we follow for other UDFs that implement return_field_from_args and not return_type
| let input = &args.arg_fields[0]; | ||
| Ok(Arc::new(Field::new( | ||
| self.name(), | ||
| self.return_type(&arg_types)?, |
| let input = &args.arg_fields[0]; | ||
| // Retained dictionaries can have null values even with non-null keys. | ||
| let nullable = input.is_nullable() | ||
| || matches!(input.data_type(), DataType::Dictionary(_, _)); |
Contributor
There was a problem hiding this comment.
why does space have this extra dictionary logic compared to soundex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of the work towards #15914
Rationale for this change
#26205 (review)
What changes are included in this PR?
Deriving nullability correctly for
soundex,space, and nativeconcat_ws.What is the testing strategy for this PR?
New unit + SLT tests.
Are there any user-facing changes?
No.