Repository navigation
Conversation
Infer Criterion mode from --criterion-namespace or BENCH_NAMESPACE and report automatic activation on stderr. Preserve listing, dry-run behaviour, and Criterion option compatibility checks. Share namespace validation between the CLI and SQL benchmark runner. Add regression coverage for mode inference, CLI precedence, and stderr output.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26210 +/- ##
==========================================
- Coverage 82.80% 82.80% -0.01%
==========================================
Files 1149 1149
Lines 452213 452272 +59
Branches 452213 452272 +59
==========================================
+ Hits 374473 374520 +47
- Misses 54945 54953 +8
- Partials 22795 22799 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Omega359
marked this pull request as ready for review
October 11, 2026 15:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem or challenge?
Running a SQL benchmark with
--criterion-namespaceorBENCH_NAMESPACEcurrently requires a separate--criterionflag. Since namespaces apply to Criterion benchmark groups, selecting a namespace should also select Criterion mode.Describe the solution you'd like
Enable Criterion when either namespace option is set. Apply the existing mode checks after inferring Criterion mode, so incompatible
--outputand--iterationsoptions still fail and--save-baselineworks. Print the inferred-mode notice to stderr to preserve stdout output.Describe alternatives you've considered
Keeping the explicit
--criterionrequirement would preserve the current behavior but require callers to specify both options.Additional context
This follows the SQL benchmark migration preparation in #24806.
Willingness to contribute
Implementation included in this draft PR.
Which issue does this PR close?
bench.shto use the newbenchmark_runner#24311 and Remove olddfbenchrunner once benchmarks are migrated to the new SQL benchmark framework #24312.Rationale for this change
Allow benchmark callers to select namespaced Criterion runs with a single option or environment variable.
What changes are included in this PR?
--criterion-namespaceandBENCH_NAMESPACEand update the CLI help.What is the testing strategy for this PR?
The benchmark-runner tests exercise argument parsing and environment handling, including a subprocess test for
BENCH_NAMESPACE. Existing tests cover invalid namespaces and distinct Criterion artifacts.Are there any user-facing changes?
Yes.
--criterion-namespaceandBENCH_NAMESPACEnow enable Criterion without an explicit--criterionflag. The runner reports inferred mode on stderr.