* modules/metadata/mod_remoteip.c (remoteip_input_filter): Log EOF while

  reading the PROXY protocol header at info level, as the peer going away;
  other read errors are still logged as errors.  PR 63893.

* test/modules/metadata/test_004_remoteip.py (test_metadata_004_06): No
  longer an expected failure.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Author: notroj

changes-entries/remoteip-pp-eof.txt

@@ -0,0 +1,3 @@
+  *) mod_remoteip: Log a connection closed before a complete PROXY protocol
+     header was received at info level rather than as an error.  PR 63893.
+     [Joe Orton]

modules/metadata/mod_remoteip.c

@@ -1134,6 +1134,14 @@ static apr_status_t remoteip_input_filter(ap_filter_t *f,
             apr_off_t got, want = ctx->need - ctx->rcvd;
 
             ret = ap_get_brigade(f->next, ctx->bb, ctx->mode, block, want);
+            if (APR_STATUS_IS_EOF(ret)) {
+                /* The peer went away before sending a whole header, as a
+                 * health check may. */
+                ap_log_cerror(APLOG_MARK, APLOG_INFO, ret, f->c, APLOGNO()
+                              "RemoteIPProxyProtocol: connection closed "
+                              "before a complete header was received");
+                return ret;
+            }
             if (ret != APR_SUCCESS) {
                 ap_log_cerror(APLOG_MARK, APLOG_ERR, ret, f->c, APLOGNO(10184)
                               "failed reading input");

test/modules/metadata/test_004_remoteip.py

@@ -206,16 +206,11 @@ def test_metadata_004_05(self, env):
         assert self.pp_request(env, hdr) == (200, self.PEER)
 
     # A health check which connects, sends an incomplete header and goes
-    # away is not an error worth logging (bug 63893 comment 12); today it
-    # is logged as one, AH10184 "failed reading input" with APR_EOF.
-    @pytest.mark.xfail(strict=True,
-                       reason="EOF while reading the PROXY header is logged "
-                              "at error level, AH10184")
+    # away is not an error worth logging (bug 63893 comment 12).
     def test_metadata_004_06(self, env):
         self.pp_install(env)
         pos = env.httpd_error_log.current_pos()
         assert self.pp_request(env, self.PP2_SIG, request=False) == (None, None)
         logged = env.httpd_error_log.wait_for(re.compile(r".*AH10184"), pos,
                                               timeout=1)
-        env.httpd_error_log.ignore_recent(lognos=["AH10184"])
         assert not logged, "peer going away mid-header was logged as an error"