HDDS-14240. Revert HDDS-13415 to separate out Refactoring and implementation of Delete Range with batch #9554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntation This reverts commit ae92a18 Change-Id: I2ed4e78d395fb48ba0769c2f8319fb6686f03a70
szetszwo
approved these changes
Dec 24, 2025
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
Please do not create Jira issue for reverting another. Just use the original ticket, like: |
Contributor
Author
I believe havong another jira for revert makes sense. This is not exactly a full exact revert so it makes sense to have a separate jira. |
Contributor
Author
|
Thank you @szetszwo for reviewing the patch |
Contributor
It fully reverts HDDS-13415, and an additioonal usage of |
Contributor
|
@swamirishi , when someone has a concern, it is better to finish the discussion first. Please don't merge the PR so early. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Revert the patch HDDS-13415 and do individual deletes on snapshot create
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14240
How was this patch tested?
Existing tests should be sufficient since we are reverting a patch