Clarify minValue intent in AggregationOperation (Double.MIN_VALUE)

[carloea2]

In AggregationOperation.scala, minValue uses Double.MIN_VALUE, which is the smallest positive double, not most-negative. Is the intent “most-negative” or “smallest non-negative”?

texera/common/workflow-operator/src/main/scala/org/apache/amber/operator/aggregate/AggregationOperation.scala

Lines 335 to 345 in 07c35d0

	private def minValue(attributeType: AttributeType): Object =
	attributeType match {
	case AttributeType.INTEGER => Integer.MIN_VALUE.asInstanceOf[Object]
	case AttributeType.DOUBLE => java.lang.Double.MIN_VALUE.asInstanceOf[Object]
	case AttributeType.LONG => java.lang.Long.MIN_VALUE.asInstanceOf[Object]
	case AttributeType.TIMESTAMP => new Timestamp(0)
	case _ =>
	throw new UnsupportedOperationException(
	"Unsupported attribute type for min value: " + attributeType
	)
	}

[chenlica]

@zuozhiw Can you chime in?

[zuozhiw]

@carloea2 thanks for spotting this, the intention is negative infinity, not smallest positive nonzero value. We should really use Double.NEGATIVE_INFINITY here. Appreciate if you could fix this bug.

[Yicong-Huang]

Agreed, @carloea2 if you could please create an issue from this discussion and fix it. Thanks!

[carloea2]

Thank you for your time to take a look at it, I think I can directly apply this change in the next PR as it is part of the code it is being changed: #4024

Is that OK for you?

Thanks,

[Yicong-Huang]

I would highly suggest to separate refactor and bug fixes. Can you please use another PR for fixing the bug?

[carloea2]

Ok, then I will wait for the PR #4024 to me merged (likely by the end of this week), and then raise the issue and PR to solve it. Please confirm if this is ok for you, thank you.

[chenlica]

@carloea2 Can you resume this discussion?

[carloea2]

Yes, I can work on this task now.

I will raise an Issue, reference this discussion and raise the PR.

[carloea2]

Issue: #4144

PR: #4145