(py) why implement as httpx.Client instead of httpx.Transport?

[vgavro]

Any reason why you decided to implement httpx.Client-like interface instead of implementing ImplitTransport(httpx.BaseTransport) which can be passed to standard Client like httpx.Client(transport=ImplitTransport(impersonate="chrome", force_http3=True))? Custom request parameters can be passed with request.extensions like httpx.Client().get("https://google.com", extensions={"force_http3": True})

1. it's a huge work to make Client part compatible (high-level part)
2. httpx is widely used already, so you can easily pass your customized httpx.Client to third-party interfaces (or pass custom transports if they inherit httpx.BaseTransport, wrap transports with retries etc). Problem here - API incompatibility + type checkers on passing implit.Client instead of httpx.Client!
3. Huge httpx ecosystem which is impossible to use with "almost same, but not the same" httpx api/client, but expected to use with custom transports.

I'm asking this, because curl-cffi also took that approach, which forced me to write https://github.com/vgavro/httpx-curl-cffi just for the sake of API compatibility to re-use httpx ecosystem (like https://github.com/will-ockmore/httpx-retries wrapper, caching wrappers, security wrappers, name it).

Thank you for your time!

[barjin]

Thank you for your interest in this project @vgavro !

impit was originally intended as a Node.js library only, with Python support being added some months after. The Node.js version of impit is a standalone library, implementing the fetch API (there is no equivalent of httpx.Transport in JS - at least not a practical one).

When implementing the Python version, we aimed to have a standalone library as well, and we modelled the API after httpx to make the usage easier for regular httpx users.

You are raising a good point, though. If you think that adding the Transport interface to impit shouldn't be that hard, we definitely could have it, just to provide a more seamless way to use impit in existing httpx projects. Feel free to open a PR if you feel like it.

Cheers!