Skip to content

Commit 19cc4e3

Browse files
committed
Merge remote-tracking branch 'origin/main' into update-use-iterators
2 parents febc4e1 + 1933e51 commit 19cc4e3

File tree

509 files changed

+9563
-2645
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

509 files changed

+9563
-2645
lines changed
Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
1+
# Source: https://github.com/arduino/tooling-project-assets/blob/main/issue-templates/forms/platform-dependent/bug-report.yml
2+
# See: https://docs.github.com/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms
3+
4+
name: Bug report
5+
description: Report a problem with the code or documentation in this repository.
6+
labels:
7+
- "type: imperfection"
8+
body:
9+
- type: textarea
10+
id: description
11+
attributes:
12+
label: Describe the problem
13+
validations:
14+
required: true
15+
- type: textarea
16+
id: reproduce
17+
attributes:
18+
label: To reproduce
19+
description: Provide the specific set of steps we can follow to reproduce the problem.
20+
validations:
21+
required: true
22+
- type: textarea
23+
id: expected
24+
attributes:
25+
label: Expected behavior
26+
description: What would you expect to happen after following those instructions?
27+
validations:
28+
required: true
29+
- type: input
30+
id: project-version
31+
attributes:
32+
label: Arduino App CLI version
33+
description: |
34+
Which version of Arduino App CLI are you using? (output of `arduino-app-cli version` executed inside the board)
35+
_This should be the most recent version available._
36+
validations:
37+
required: true
38+
- type: textarea
39+
id: additional
40+
attributes:
41+
label: Additional context
42+
description: Add any additional information here.
43+
validations:
44+
required: false
45+
- type: checkboxes
46+
id: checklist
47+
attributes:
48+
label: Issue checklist
49+
description: Please double-check that you have done each of the following things before submitting the issue.
50+
options:
51+
- label: I searched for previous reports in [the issue tracker](https://github.com/arduino/arduino-app-cli/issues?q=)
52+
required: true
53+
- label: I verified the problem still occurs when using the latest version
54+
required: true
55+
- label: My report contains all necessary details
56+
required: true
Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
# Source: https://github.com/arduino/tooling-project-assets/blob/main/issue-templates/forms/platform-dependent/bug-report.yml
2+
# See: https://docs.github.com/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms
3+
4+
name: Feature request
5+
description: Suggest an enhancement to this project.
6+
labels:
7+
- "type: enhancement"
8+
body:
9+
- type: textarea
10+
id: description
11+
attributes:
12+
label: Describe the request
13+
validations:
14+
required: true
15+
- type: textarea
16+
id: current
17+
attributes:
18+
label: Describe the current behavior
19+
description: |
20+
What is the current behavior of Arduino App CLI in relation to your request?
21+
How can we reproduce that behavior?
22+
validations:
23+
required: true
24+
- type: input
25+
id: project-version
26+
attributes:
27+
label: Arduino App CLI version
28+
description: |
29+
Which version of Arduino App CLI are you using? (output of `arduino-app-cli version` executed inside the board)
30+
_This should be the most recent version available._
31+
validations:
32+
required: true
33+
- type: textarea
34+
id: additional
35+
attributes:
36+
label: Additional context
37+
description: Add any additional information here.
38+
validations:
39+
required: false
40+
- type: checkboxes
41+
id: checklist
42+
attributes:
43+
label: Issue checklist
44+
description: Please double-check that you have done each of the following things before submitting the issue.
45+
options:
46+
- label: I searched for previous requests in [the issue tracker](https://github.com/arduino/arduino-app-cli/issues?q=)
47+
required: true
48+
- label: I verified the feature was still missing when using the latest version
49+
required: true
50+
- label: My request contains all necessary details
51+
required: true

.github/workflows/openapi-spec.yml

Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
name: Check for breaking OpenAPI changes
2+
3+
on:
4+
push:
5+
pull_request:
6+
paths:
7+
- "internal/api/docs/openapi.yaml"
8+
workflow_dispatch:
9+
inputs:
10+
target_branch:
11+
description: "Branch to compare against (used in manual runs)"
12+
required: false
13+
default: "main"
14+
15+
jobs:
16+
oasdiff:
17+
name: OASDiff Check
18+
runs-on: ubuntu-latest
19+
20+
steps:
21+
- name: Checkout repository
22+
uses: actions/checkout@v4
23+
with:
24+
fetch-depth: 0
25+
26+
- name: Set up Go
27+
uses: actions/setup-go@v5
28+
with:
29+
go-version-file: go.mod
30+
31+
- name: Install oasdiff
32+
run: go install github.com/oasdiff/[email protected]
33+
34+
- name: Add Go bin to PATH
35+
run: echo "${HOME}/go/bin" >> $GITHUB_PATH
36+
37+
- name: Determine base branch and fetch OpenAPI file
38+
id: get_base_openapi
39+
run: |
40+
BASE_BRANCH="${{ github.event.pull_request.base.ref || github.event.inputs.target_branch || 'main' }}"
41+
echo "Comparing against base branch: $BASE_BRANCH"
42+
git fetch origin "$BASE_BRANCH"
43+
git show origin/"$BASE_BRANCH":internal/api/docs/openapi.yaml > /tmp/base-openapi.yaml \
44+
|| (touch /tmp/base-openapi.yaml; echo "No base OpenAPI file found, using empty file.")
45+
46+
- name: Run oasdiff to check for breaking changes
47+
run: |
48+
if oasdiff breaking --format githubactions --filter-extension request-parameter-enum-value-added --fail-on ERR /tmp/base-openapi.yaml internal/api/docs/openapi.yaml; then
49+
echo "✅ No breaking changes detected in OpenAPI spec."
50+
else
51+
echo "❌ Breaking changes detected! Please review the OpenAPI spec."
52+
exit 1
53+
fi

.github/workflows/test-update.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,3 +27,15 @@ jobs:
2727
GH_TOKEN: ${{ secrets.ARDUINOBOT_TOKEN }}
2828
run: |
2929
go tool task test:update
30+
31+
- name: Slack notification of unexpected failure
32+
if: ${{ failure() }}
33+
uses: rtCamp/action-slack-notify@v2
34+
env:
35+
SLACK_WEBHOOK: ${{ secrets.TEAM_TOOLING_CHANNEL_SLACK_WEBHOOK }}
36+
SLACK_MESSAGE: |
37+
:warning::warning::warning::warning:
38+
WARNING: ${{ github.repository }} ${{ github.workflow }} workflow run had an unexpected failure!!!
39+
:warning::warning::warning::warning:
40+
SLACK_COLOR: danger
41+
MSG_MINIMAL: true

0 commit comments

Comments
 (0)