fix(localize): use Object.hasOwn for placeholder lookup in translate

Author: arshsmith1

packages/localize/src/utils/src/translations.ts

@@ -68,7 +68,7 @@ export function translate(
   return [
     translation.messageParts,
     translation.placeholderNames.map((placeholder) => {
-      if (message.substitutions.hasOwnProperty(placeholder)) {
+      if (Object.hasOwn(message.substitutions, placeholder)) {
         return message.substitutions[placeholder];
       } else {
         throw new Error(

packages/localize/src/utils/test/translations_spec.ts

@@ -137,6 +137,17 @@ describe('utils', () => {
       );
     });
 
+    it('should substitute a placeholder whose name shadows an Object.prototype member', () => {
+      // A placeholder legitimately named `hasOwnProperty` puts that key on the
+      // substitutions object, so calling it as a method would throw a TypeError.
+      expect(
+        doTranslate(
+          {'abc{$hasOwnProperty}def': 'abc{$hasOwnProperty}def'},
+          parts`abc${1 + 2}:hasOwnProperty:def`,
+        ),
+      ).toEqual(parts`abc${3}def`);
+    });
+
     it('(with identity translations) should render template literals as-is', () => {
       const translations = {
         'abc': 'abc',