Skip to content

Commit d9c1d6e

Browse files
committed
feat: use new parenthesized_range in generate_comparison helper
1 parent 03be8b9 commit d9c1d6e

File tree

4 files changed

+11
-12
lines changed

4 files changed

+11
-12
lines changed

crates/ruff_linter/src/rules/pycodestyle/rules/literal_comparisons.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,6 @@ pub(crate) fn literal_comparisons(checker: &Checker, compare: &ast::ExprCompare)
378378
.copied()
379379
.collect::<Vec<_>>();
380380

381-
let comment_ranges = checker.comment_ranges();
382381
let tokens = checker.tokens();
383382
let source = checker.source();
384383

@@ -405,7 +404,7 @@ pub(crate) fn literal_comparisons(checker: &Checker, compare: &ast::ExprCompare)
405404
&ops,
406405
&compare.comparators,
407406
compare.into(),
408-
comment_ranges,
407+
tokens,
409408
source,
410409
)
411410
}
@@ -415,7 +414,7 @@ pub(crate) fn literal_comparisons(checker: &Checker, compare: &ast::ExprCompare)
415414
&ops,
416415
&compare.comparators,
417416
compare.into(),
418-
comment_ranges,
417+
tokens,
419418
source,
420419
),
421420
};

crates/ruff_linter/src/rules/pycodestyle/rules/not_tests.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ pub(crate) fn not_tests(checker: &Checker, unary_op: &ast::ExprUnaryOp) {
107107
&[CmpOp::NotIn],
108108
comparators,
109109
unary_op.into(),
110-
checker.comment_ranges(),
110+
checker.tokens(),
111111
checker.source(),
112112
),
113113
unary_op.range(),
@@ -127,7 +127,7 @@ pub(crate) fn not_tests(checker: &Checker, unary_op: &ast::ExprUnaryOp) {
127127
&[CmpOp::IsNot],
128128
comparators,
129129
unary_op.into(),
130-
checker.comment_ranges(),
130+
checker.tokens(),
131131
checker.source(),
132132
),
133133
unary_op.range(),

crates/ruff_linter/src/rules/refurb/rules/single_item_membership_test.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ pub(crate) fn single_item_membership_test(
9595
&[membership_test.replacement_op()],
9696
std::slice::from_ref(item),
9797
expr.into(),
98-
checker.comment_ranges(),
98+
checker.tokens(),
9999
checker.source(),
100100
),
101101
expr.range(),

crates/ruff_python_ast/src/helpers.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,14 @@ use std::path::Path;
33

44
use rustc_hash::FxHashMap;
55

6-
use ruff_python_trivia::{CommentRanges, SimpleTokenKind, SimpleTokenizer, indentation_at_offset};
6+
use ruff_python_trivia::{SimpleTokenKind, SimpleTokenizer, indentation_at_offset};
77
use ruff_source_file::LineRanges;
88
use ruff_text_size::{Ranged, TextLen, TextRange, TextSize};
99

1010
use crate::name::{Name, QualifiedName, QualifiedNameBuilder};
11-
use crate::parenthesize::parenthesized_range;
1211
use crate::statement_visitor::StatementVisitor;
12+
use crate::token::Tokens;
13+
use crate::token::parenthesized_range;
1314
use crate::visitor::Visitor;
1415
use crate::{
1516
self as ast, Arguments, AtomicNodeIndex, CmpOp, DictItem, ExceptHandler, Expr, ExprNoneLiteral,
@@ -1474,7 +1475,7 @@ pub fn generate_comparison(
14741475
ops: &[CmpOp],
14751476
comparators: &[Expr],
14761477
parent: AnyNodeRef,
1477-
comment_ranges: &CommentRanges,
1478+
tokens: &Tokens,
14781479
source: &str,
14791480
) -> String {
14801481
let start = left.start();
@@ -1483,8 +1484,7 @@ pub fn generate_comparison(
14831484

14841485
// Add the left side of the comparison.
14851486
contents.push_str(
1486-
&source[parenthesized_range(left.into(), parent, comment_ranges, source)
1487-
.unwrap_or(left.range())],
1487+
&source[parenthesized_range(left.into(), parent, tokens).unwrap_or(left.range())],
14881488
);
14891489

14901490
for (op, comparator) in ops.iter().zip(comparators) {
@@ -1504,7 +1504,7 @@ pub fn generate_comparison(
15041504

15051505
// Add the right side of the comparison.
15061506
contents.push_str(
1507-
&source[parenthesized_range(comparator.into(), parent, comment_ranges, source)
1507+
&source[parenthesized_range(comparator.into(), parent, tokens)
15081508
.unwrap_or(comparator.range())],
15091509
);
15101510
}

0 commit comments

Comments
 (0)