AXON-1331 Rich text editor (Bitbucket) #1146
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
om-ukr
changed the title
om-ukr
force-pushed
the
AXON-1331-Rich-text-editor-bitbucket
branch
5 times, most recently
from
5708c90 to
eaf084c
Compare
om-ukr
changed the title
…skit/icon": "^28.3.0",
* AXON-1337: Add AKE with default functionality to comments area * AXON-1337: Remove unused CSS
* AXON-1333: Add mentions provider for BB AKE * AXON-1333: Fix mentions for DC
* AXON-1339: fix/update unit tests for BB AKE * AXON-1339: update timers * AXON-1339: fix failed tests
om-ukr
force-pushed
the
AXON-1331-Rich-text-editor-bitbucket
branch
from
8bc894e to
9c8f5f0
Compare
![atlassian[bot]](https://avatars.githubusercontent.com/in/14320?s=60&v=4){kind=small}
| onCancel?: () => void; | ||
| fetchUsers?: (input: string) => Promise<User[]>; | ||
| handleEditorFocus: (isFocused: boolean) => void; | ||
| mentionsProvider: AtlascodeMentionProvider | undefined; |
Contributor
There was a problem hiding this comment.
🔎 Code Design - Model Structure
The mentionsProvider prop should be marked as optional in the interface to match its usage pattern.
Suggested change
| mentionsProvider: AtlascodeMentionProvider | undefined; | |
| mentionsProvider?: AtlascodeMentionProvider | undefined; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Is This Change?
How Has This Been Tested?
Basic checks:
npm run lintnpm run testAdvanced checks:
Recommendations: