ref: normalize emitted object keys through tsObjectKey

(cherry picked from commit 19a4f0e5fae0feea51c397589f81f0c28bffed36)

Author: ryukzak

src/api/writer-generator/typescript/name.ts

@@ -103,3 +103,13 @@ export const tsExtensionFlatTypeName = (profileName: string, extensionName: stri
 export const tsSliceStaticName = (name: string): string => name.replace(/\[x\]/g, "").replace(/[^a-zA-Z0-9_$]/g, "_");
 
 export const tsValueFieldName = (id: TypeIdentifier): string => `value${uppercaseFirstLetter(id.name)}`;
+
+const TS_IDENTIFIER_RE = /^[A-Za-z_$][A-Za-z0-9_$]*$/;
+
+/** An object-literal property key for emitted value code: bare when it is a
+ *  valid identifier, quoted otherwise — and computed for "__proto__", whose
+ *  plain form is the prototype setter and would not create an own property. */
+export const tsObjectKey = (key: string): string => {
+    if (key === "__proto__") return '["__proto__"]';
+    return TS_IDENTIFIER_RE.test(key) ? key : JSON.stringify(key);
+};

src/api/writer-generator/typescript/writer.ts

@@ -27,6 +27,7 @@ import {
     tsModuleFileName,
     tsModuleName,
     tsNameFromCanonical,
+    tsObjectKey,
     tsPackageDir,
     tsProfileModuleFileName,
     tsResourceName,
@@ -557,7 +558,7 @@ export class TypeScript extends Writer<TypeScriptOptions> {
                         this.curlyBlock(["displays:"], () => {
                             for (const concept of concepts) {
                                 if (concept.display !== undefined)
-                                    this.line(`[${JSON.stringify(concept.code)}]: ${JSON.stringify(concept.display)},`);
+                                    this.line(`${tsObjectKey(concept.code)}: ${JSON.stringify(concept.display)},`);
                             }
                         }, [","]);
                     }

test/unit/api/writer-generator/typescript/terminology.test.ts

@@ -112,8 +112,8 @@ describe("TypeScript terminology surface", () => {
               contentMode: "complete",
               codes: ["second", "first"],
               displays: {
-                  ["second"]: "Second display",
-                  ["first"]: "First display",
+                  second: "Second display",
+                  first: "First display",
               },
           } as const;
           export type CompleteExampleCode = (typeof CompleteExampleCodeSystem.codes)[number];
@@ -231,7 +231,7 @@ describe("TypeScript terminology surface", () => {
             output.indexOf(JSON.stringify(sourceConcepts[1].code)),
         );
         for (const concept of sourceConcepts) {
-            expect(output).toContain(`[${JSON.stringify(concept.code)}]: ${JSON.stringify(concept.display)}`);
+            expect(output).toContain(`${concept.code}: ${JSON.stringify(concept.display)}`);
         }
     });
 
@@ -274,12 +274,8 @@ describe("TypeScript terminology surface", () => {
         ]);
 
         expect(output).toContain('codes: ["parent", "child", "sibling"]');
-        expect(output.indexOf('["parent"]: "Parent display"')).toBeLessThan(
-            output.indexOf('["child"]: "Child display"'),
-        );
-        expect(output.indexOf('["child"]: "Child display"')).toBeLessThan(
-            output.indexOf('["sibling"]: "Sibling display"'),
-        );
+        expect(output.indexOf('parent: "Parent display"')).toBeLessThan(output.indexOf('child: "Child display"'));
+        expect(output.indexOf('child: "Child display"')).toBeLessThan(output.indexOf('sibling: "Sibling display"'));
     });
 
     it("handles deeply nested concepts without exhausting the stack", async () => {
@@ -308,7 +304,7 @@ describe("TypeScript terminology surface", () => {
         ]);
 
         expect(output).toContain('codes: ["code-0", "code-1"');
-        expect(output).toContain(`["code-${depth}"]: "Display ${depth}"`);
+        expect(output).toContain(`"code-${depth}": "Display ${depth}"`);
     });
 
     it("fails deterministically when hierarchical concepts repeat a code", async () => {