meson: use common ldflags

Author: matt-sm

foreign_cc/meson.bzl

@@ -71,6 +71,7 @@ def _create_meson_script(configureParameters):
     tools = get_tools_info(ctx)
     flags = get_flags_info(ctx)
     script = pkgconfig_script(inputs.ext_build_dirs)
+    build_options = _get_options(ctx)
 
     # CFLAGS and CXXFLAGS are also set in foreign_cc/private/cmake_script.bzl, so that meson
     # can use the intended tools.
@@ -141,13 +142,20 @@ def _create_meson_script(configureParameters):
 
         target_args[target_name] = args
 
+    # Append shared flags to build options
+    if flags.cxx_linker_shared and ctx.attr.shared_ldflags_option:
+        if ctx.attr.shared_ldflags_option in build_options:
+            fail("cannot override existing build option: {}".format(ctx.attr.shared_ldflags_option))
+
+        build_options[ctx.attr.shared_ldflags_option] = _list_to_str_repr(flags.cxx_linker_shared)
+
     script.append("{meson} setup --prefix={install_dir} {setup_args} {options} {source_dir}".format(
         meson = meson_path,
         install_dir = "$$INSTALLDIR$$",
         setup_args = " ".join(target_args.get("setup", [])),
         options = " ".join([
-            "-D{}=\"{}\"".format(key, ctx.attr.options[key])
-            for key in ctx.attr.options
+            "\"-D{}={}\"".format(key, build_options[key])
+            for key in build_options
         ]),
         source_dir = "$$EXT_BUILD_ROOT$$/" + root,
     ))
@@ -225,6 +233,10 @@ def _attrs():
             doc = "__deprecated__: please use `target_args` with `'setup'` target key.",
             mandatory = False,
         ),
+        "shared_ldflags_option": attr.string(
+            doc = "Name of additional setup option that will contain shared ldflags.",
+            mandatory = False,
+        ),
         "target_args": attr.string_list_dict(
             doc = "Dict of arguments for each of the Meson targets. The " +
                   "target name is the key and the list of args is the value.",
@@ -300,3 +312,18 @@ def _absolutize(workspace_name, text, force = False):
 
 def _join_flags_list(workspace_name, flags):
     return " ".join([_absolutize(workspace_name, flag) for flag in flags])
+
+def _get_options(ctx):
+    # create an unfrozen dict with build options
+    opts = {}
+    opts.update(ctx.attr.options)
+    return opts
+
+def _list_to_str_repr(lst):
+    # see https://mesonbuild.com/Build-options.html#using-build-options
+    # meson array build options with elements that contain commas need to be in the format
+    # "-Doption=['a,b', 'c,d']"
+    quoted = []
+    for item in lst:
+        quoted.append("'" + item + "'")
+    return "[" + ", ".join(quoted) + "]"