Increase the number of supported clustered decals if the PARTIALLY_BOUND_BINDING_ARRAY wgpu feature is present.
#22028
+33
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PARTIALLY_BOUND_BINDING_ARRAY` `wgpu` feature is present. The current clustered decal code predates `PARTIALLY_BOUND_BINDING_ARRAY` support in `wgpu`. As a result, only 8 clustered decals are allowed in the scene in order to avoid paying a high cost even if no decals of that type are present. This limitation makes Bevy's current clustered decal support insufficient for many use cases (e.g. bullet holes), so this patch increases the limit from 8 to 1024 if the `wgpu` features include `PARTIALLY_BOUND_BINDING_ARRAY`.
JMS55
approved these changes
Dec 4, 2025
james7132
reviewed
Dec 4, 2025
tychedelia
approved these changes
Dec 4, 2025
IceSentry
approved these changes
Dec 4, 2025
Contributor
IceSentry
left a comment
IceSentry
left a comment
There was a problem hiding this comment.
I'd like a comment explaining the 1024 limit but other than that LGTM
kfc35
approved these changes
Dec 5, 2025
pcwalton
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current clustered decal code predates
PARTIALLY_BOUND_BINDING_ARRAYsupport inwgpu. As a result, only 8 clustered decals are allowed in the scene in order to avoid paying a high cost even if no decals of that type are present. This limitation makes Bevy's current clustered decal support insufficient for many use cases (e.g. bullet holes), so this patch increases the limit from 8 to 1024 if thewgpufeatures includePARTIALLY_BOUND_BINDING_ARRAY.