Skip to content

Commit fe4895d

Browse files
authored
[PM-28264] Consolidate and update the UI for key connector migration/confirmation (#17642)
* Consolidate the RemovePasswordComponent * Add getting confirmation details for confirm key connector * Add missing message
1 parent 93640e6 commit fe4895d

30 files changed

+496
-206
lines changed

apps/browser/src/_locales/en/messages.json

Lines changed: 39 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3252,9 +3252,6 @@
32523252
"copyCustomFieldNameNotUnique": {
32533253
"message": "No unique identifier found."
32543254
},
3255-
"removeMasterPasswordForOrganizationUserKeyConnector": {
3256-
"message": "A master password is no longer required for members of the following organization. Please confirm the domain below with your organization administrator."
3257-
},
32583255
"organizationName": {
32593256
"message": "Organization name"
32603257
},
@@ -5891,6 +5888,45 @@
58915888
"cardNumberLabel": {
58925889
"message": "Card number"
58935890
},
5891+
"removeMasterPasswordForOrgUserKeyConnector":{
5892+
"message": "Your organization is no longer using master passwords to log into Bitwarden. To continue, verify the organization and domain."
5893+
},
5894+
"continueWithLogIn": {
5895+
"message": "Continue with log in"
5896+
},
5897+
"doNotContinue": {
5898+
"message": "Do not continue"
5899+
},
5900+
"domain": {
5901+
"message": "Domain"
5902+
},
5903+
"keyConnectorDomainTooltip": {
5904+
"message": "This domain will store your account encryption keys, so make sure you trust it. If you're not sure, check with your admin."
5905+
},
5906+
"verifyYourOrganization": {
5907+
"message": "Verify your organization to log in"
5908+
},
5909+
"organizationVerified":{
5910+
"message": "Organization verified"
5911+
},
5912+
"domainVerified":{
5913+
"message": "Domain verified"
5914+
},
5915+
"leaveOrganizationContent": {
5916+
"message": "If you don't verify your organization, your access to the organization will be revoked."
5917+
},
5918+
"leaveNow": {
5919+
"message": "Leave now"
5920+
},
5921+
"verifyYourDomainToLogin": {
5922+
"message": "Verify your domain to log in"
5923+
},
5924+
"verifyYourDomainDescription": {
5925+
"message": "To continue with log in, verify this domain."
5926+
},
5927+
"confirmKeyConnectorOrganizationUserDescription": {
5928+
"message": "To continue with log in, verify the organization and domain."
5929+
},
58945930
"sessionTimeoutSettingsAction": {
58955931
"message": "Timeout action"
58965932
},

apps/browser/src/key-management/key-connector/remove-password.component.html

Lines changed: 0 additions & 51 deletions
This file was deleted.

apps/browser/src/key-management/key-connector/remove-password.component.ts

Lines changed: 0 additions & 14 deletions
This file was deleted.

apps/browser/src/popup/app-routing.module.ts

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,11 @@ import {
4343
TwoFactorAuthGuard,
4444
} from "@bitwarden/auth/angular";
4545
import { AnonLayoutWrapperComponent, AnonLayoutWrapperData } from "@bitwarden/components";
46-
import { LockComponent, ConfirmKeyConnectorDomainComponent } from "@bitwarden/key-management-ui";
46+
import {
47+
LockComponent,
48+
ConfirmKeyConnectorDomainComponent,
49+
RemovePasswordComponent,
50+
} from "@bitwarden/key-management-ui";
4751

4852
import { AccountSwitcherComponent } from "../auth/popup/account-switching/account-switcher.component";
4953
import { AuthExtensionRoute } from "../auth/popup/constants/auth-extension-route.constant";
@@ -59,7 +63,6 @@ import { NotificationsSettingsComponent } from "../autofill/popup/settings/notif
5963
import { PremiumV2Component } from "../billing/popup/settings/premium-v2.component";
6064
import { PhishingWarning } from "../dirt/phishing-detection/popup/phishing-warning.component";
6165
import { ProtectedByComponent } from "../dirt/phishing-detection/popup/protected-by-component";
62-
import { RemovePasswordComponent } from "../key-management/key-connector/remove-password.component";
6366
import BrowserPopupUtils from "../platform/browser/browser-popup-utils";
6467
import { popupRouterCacheGuard } from "../platform/popup/view-cache/popup-router-cache.service";
6568
import { RouteCacheOptions } from "../platform/services/popup-view-cache-background.service";
@@ -188,9 +191,22 @@ const routes: Routes = [
188191
},
189192
{
190193
path: "remove-password",
191-
component: RemovePasswordComponent,
194+
component: ExtensionAnonLayoutWrapperComponent,
192195
canActivate: [authGuard],
193196
data: { elevation: 1 } satisfies RouteDataProperties,
197+
children: [
198+
{
199+
path: "",
200+
component: RemovePasswordComponent,
201+
data: {
202+
pageTitle: {
203+
key: "verifyYourOrganization",
204+
},
205+
showBackButton: false,
206+
pageIcon: LockIcon,
207+
} satisfies ExtensionAnonLayoutWrapperData,
208+
},
209+
],
194210
},
195211
{
196212
path: "view-cipher",
@@ -646,7 +662,7 @@ const routes: Routes = [
646662
component: ConfirmKeyConnectorDomainComponent,
647663
data: {
648664
pageTitle: {
649-
key: "confirmKeyConnectorDomain",
665+
key: "verifyYourOrganization",
650666
},
651667
showBackButton: true,
652668
pageIcon: DomainIcon,

apps/browser/src/popup/app.module.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ import { CurrentAccountComponent } from "../auth/popup/account-switching/current
2828
import { AccountSecurityComponent } from "../auth/popup/settings/account-security.component";
2929
import { AutofillComponent } from "../autofill/popup/settings/autofill.component";
3030
import { NotificationsSettingsComponent } from "../autofill/popup/settings/notifications.component";
31-
import { RemovePasswordComponent } from "../key-management/key-connector/remove-password.component";
3231
import { PopOutComponent } from "../platform/popup/components/pop-out.component";
3332
import { PopupFooterComponent } from "../platform/popup/layout/popup-footer.component";
3433
import { PopupHeaderComponent } from "../platform/popup/layout/popup-header.component";
@@ -85,13 +84,7 @@ import "../platform/popup/locales";
8584
CalloutModule,
8685
LinkModule,
8786
],
88-
declarations: [
89-
AppComponent,
90-
ColorPasswordPipe,
91-
ColorPasswordCountPipe,
92-
TabsV2Component,
93-
RemovePasswordComponent,
94-
],
87+
declarations: [AppComponent, ColorPasswordPipe, ColorPasswordCountPipe, TabsV2Component],
9588
exports: [CalloutModule],
9689
providers: [CurrencyPipe, DatePipe],
9790
bootstrap: [AppComponent],

apps/desktop/src/app/app-routing.module.ts

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,14 +42,17 @@ import {
4242
} from "@bitwarden/auth/angular";
4343
import { FeatureFlag } from "@bitwarden/common/enums/feature-flag.enum";
4444
import { AnonLayoutWrapperComponent, AnonLayoutWrapperData } from "@bitwarden/components";
45-
import { LockComponent, ConfirmKeyConnectorDomainComponent } from "@bitwarden/key-management-ui";
45+
import {
46+
LockComponent,
47+
ConfirmKeyConnectorDomainComponent,
48+
RemovePasswordComponent,
49+
} from "@bitwarden/key-management-ui";
4650

4751
import { maxAccountsGuardFn } from "../auth/guards/max-accounts.guard";
4852
import { reactiveUnlockVaultGuard } from "../autofill/guards/reactive-vault-guard";
4953
import { Fido2CreateComponent } from "../autofill/modal/credentials/fido2-create.component";
5054
import { Fido2ExcludedCiphersComponent } from "../autofill/modal/credentials/fido2-excluded-ciphers.component";
5155
import { Fido2VaultComponent } from "../autofill/modal/credentials/fido2-vault.component";
52-
import { RemovePasswordComponent } from "../key-management/key-connector/remove-password.component";
5356
import { VaultV2Component } from "../vault/app/vault/vault-v2.component";
5457
import { VaultComponent } from "../vault/app/vault-v3/vault.component";
5558

@@ -117,11 +120,6 @@ const routes: Routes = [
117120
component: SendComponent,
118121
canActivate: [authGuard],
119122
},
120-
{
121-
path: "remove-password",
122-
component: RemovePasswordComponent,
123-
canActivate: [authGuard],
124-
},
125123
{
126124
path: "fido2-assertion",
127125
component: Fido2VaultComponent,
@@ -327,13 +325,24 @@ const routes: Routes = [
327325
pageIcon: LockIcon,
328326
} satisfies AnonLayoutWrapperData,
329327
},
328+
{
329+
path: "remove-password",
330+
component: RemovePasswordComponent,
331+
canActivate: [authGuard],
332+
data: {
333+
pageTitle: {
334+
key: "verifyYourOrganization",
335+
},
336+
pageIcon: LockIcon,
337+
} satisfies RouteDataProperties & AnonLayoutWrapperData,
338+
},
330339
{
331340
path: "confirm-key-connector-domain",
332341
component: ConfirmKeyConnectorDomainComponent,
333342
canActivate: [],
334343
data: {
335344
pageTitle: {
336-
key: "confirmKeyConnectorDomain",
345+
key: "verifyYourOrganization",
337346
},
338347
pageIcon: DomainIcon,
339348
} satisfies RouteDataProperties & AnonLayoutWrapperData,

apps/desktop/src/app/app.module.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import { DeleteAccountComponent } from "../auth/delete-account.component";
1515
import { LoginModule } from "../auth/login/login.module";
1616
import { SshAgentService } from "../autofill/services/ssh-agent.service";
1717
import { PremiumComponent } from "../billing/app/accounts/premium.component";
18-
import { RemovePasswordComponent } from "../key-management/key-connector/remove-password.component";
1918
import { VaultFilterModule } from "../vault/app/vault/vault-filter/vault-filter.module";
2019
import { VaultV2Component } from "../vault/app/vault/vault-v2.component";
2120

@@ -50,7 +49,6 @@ import { SharedModule } from "./shared/shared.module";
5049
ColorPasswordCountPipe,
5150
HeaderComponent,
5251
PremiumComponent,
53-
RemovePasswordComponent,
5452
SearchComponent,
5553
],
5654
providers: [SshAgentService],

apps/desktop/src/key-management/key-connector/remove-password.component.html

Lines changed: 0 additions & 20 deletions
This file was deleted.

apps/desktop/src/key-management/key-connector/remove-password.component.ts

Lines changed: 0 additions & 12 deletions
This file was deleted.

apps/desktop/src/locales/en/messages.json

Lines changed: 39 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2637,9 +2637,6 @@
26372637
"removedMasterPassword": {
26382638
"message": "Master password removed"
26392639
},
2640-
"removeMasterPasswordForOrganizationUserKeyConnector": {
2641-
"message": "A master password is no longer required for members of the following organization. Please confirm the domain below with your organization administrator."
2642-
},
26432640
"organizationName": {
26442641
"message": "Organization name"
26452642
},
@@ -4337,6 +4334,45 @@
43374334
"upgradeToPremium": {
43384335
"message": "Upgrade to Premium"
43394336
},
4337+
"removeMasterPasswordForOrgUserKeyConnector":{
4338+
"message": "Your organization is no longer using master passwords to log into Bitwarden. To continue, verify the organization and domain."
4339+
},
4340+
"continueWithLogIn": {
4341+
"message": "Continue with log in"
4342+
},
4343+
"doNotContinue": {
4344+
"message": "Do not continue"
4345+
},
4346+
"domain": {
4347+
"message": "Domain"
4348+
},
4349+
"keyConnectorDomainTooltip": {
4350+
"message": "This domain will store your account encryption keys, so make sure you trust it. If you're not sure, check with your admin."
4351+
},
4352+
"verifyYourOrganization": {
4353+
"message": "Verify your organization to log in"
4354+
},
4355+
"organizationVerified":{
4356+
"message": "Organization verified"
4357+
},
4358+
"domainVerified":{
4359+
"message": "Domain verified"
4360+
},
4361+
"leaveOrganizationContent": {
4362+
"message": "If you don't verify your organization, your access to the organization will be revoked."
4363+
},
4364+
"leaveNow": {
4365+
"message": "Leave now"
4366+
},
4367+
"verifyYourDomainToLogin": {
4368+
"message": "Verify your domain to log in"
4369+
},
4370+
"verifyYourDomainDescription": {
4371+
"message": "To continue with log in, verify this domain."
4372+
},
4373+
"confirmKeyConnectorOrganizationUserDescription": {
4374+
"message": "To continue with log in, verify the organization and domain."
4375+
},
43404376
"sessionTimeoutSettingsAction": {
43414377
"message": "Timeout action"
43424378
},

0 commit comments

Comments
 (0)