consolidate allowed-os checks

Author: theodore-s-beers

cmd/localtest.go

@@ -105,7 +105,7 @@ func readLocalCLIData(path string) (api.CLIData, error) {
 
 func validateAllowedOS(data api.CLIData) error {
 	if len(data.AllowedOperatingSystems) == 0 {
-		return nil
+		return errors.New("lesson does not specify any allowed operating systems")
 	}
 
 	if slices.Contains(data.AllowedOperatingSystems, runtime.GOOS) {

cmd/submit.go

@@ -5,7 +5,6 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
-	"runtime"
 	"time"
 
 	"github.com/bootdotdev/bootdev/checks"
@@ -55,16 +54,8 @@ func submissionHandler(cmd *cobra.Command, args []string) error {
 	}
 
 	data := lesson.Lesson.LessonDataCLI.CLIData
-
-	isAllowedOS := false
-	for _, system := range data.AllowedOperatingSystems {
-		if system == runtime.GOOS {
-			isAllowedOS = true
-		}
-	}
-
-	if !isAllowedOS {
-		return fmt.Errorf("lesson is not supported for your operating system (%s); try again with one of the following: %v", runtime.GOOS, data.AllowedOperatingSystems)
+	if err := validateAllowedOS(data); err != nil {
+		return err
 	}
 
 	overrideBaseURL := viper.GetString("override_base_url")