ensure powershell commands return utf-8 output

Author: theodore-s-beers

checks/cli.go

@@ -94,6 +94,9 @@ func runCLICommandWithOutputLimit(
 	result.FinalCommand = finalCommand
 	result.Command = command
 
+	if shell.commandFlag == "-Command" {
+		finalCommand = "[Console]::OutputEncoding = [System.Text.UTF8Encoding]::new($false); " + finalCommand
+	}
 	cmd := exec.Command(shell.path, shell.commandFlag, finalCommand)
 
 	cmd.Env = append(os.Environ(), "LANG=en_US.UTF-8")

checks/cli_test.go

@@ -1,6 +1,7 @@
 package checks
 
 import (
+	"encoding/json"
 	"runtime"
 	"testing"
 
@@ -167,3 +168,29 @@ func TestParseStdoutVariablesRejectsInvalidConfiguration(t *testing.T) {
 		})
 	}
 }
+
+func TestRunCLICommandPowerShellUTF8(t *testing.T) {
+	shell := defaultShell()
+	if runtime.GOOS != "windows" {
+		var err error
+		shell, err = resolveShell("pwsh")
+		if err != nil {
+			t.Skipf("PowerShell is unavailable: %v", err)
+		}
+	}
+
+	result := runCLICommand(api.CLIStepCLICommand{
+		Command: `'• Żółć' | ConvertTo-Json -Compress`,
+	}, map[string]string{}, shell)
+	if result.Err != "" || result.ExitCode != 0 {
+		t.Fatalf("error = %q, exit code = %d, stderr = %q", result.Err, result.ExitCode, result.Stderr)
+	}
+
+	var got string
+	if err := json.Unmarshal([]byte(result.Stdout), &got); err != nil {
+		t.Fatalf("invalid JSON output %q: %v", result.Stdout, err)
+	}
+	if got != "• Żółć" {
+		t.Fatalf("decoded output = %q, want %q", got, "• Żółć")
+	}
+}