PR feedback

Author: AbhiPrasad

py/src/braintrust/integrations/anthropic/_utils.py

@@ -101,13 +101,14 @@ def extract_anthropic_usage(usage: Any) -> tuple[dict[str, float], dict[str, Any
     if "prompt_cache_creation_tokens" not in metrics and cache_creation_breakdown:
         metrics["prompt_cache_creation_tokens"] = sum(cache_creation_breakdown)
 
-    total_prompt_tokens = (
-        metrics.get("prompt_tokens", 0)
-        + metrics.get("prompt_cached_tokens", 0)
-        + metrics.get("prompt_cache_creation_tokens", 0)
-    )
-    metrics["prompt_tokens"] = total_prompt_tokens
-    metrics["tokens"] = total_prompt_tokens + metrics.get("completion_tokens", 0)
+    if metrics:
+        total_prompt_tokens = (
+            metrics.get("prompt_tokens", 0)
+            + metrics.get("prompt_cached_tokens", 0)
+            + metrics.get("prompt_cache_creation_tokens", 0)
+        )
+        metrics["prompt_tokens"] = total_prompt_tokens
+        metrics["tokens"] = total_prompt_tokens + metrics.get("completion_tokens", 0)
 
     metadata = {
         f"usage_{name}": value

py/src/braintrust/integrations/anthropic/test_anthropic.py

@@ -548,6 +548,13 @@ def test_setup_creates_spans(memory_logger):
     )
 
     usage = message.usage
+
+    spans = memory_logger.pop()
+    assert len(spans) == 1
+    span = spans[0]
+    assert span["metadata"]["model"] == MODEL
+    assert span["metadata"]["provider"] == "anthropic"
+
     cache_creation = getattr(usage, "cache_creation", None)
     if cache_creation is None:
         pytest.skip("Anthropic SDK version does not expose nested cache_creation usage fields")
@@ -559,11 +566,6 @@ def test_setup_creates_spans(memory_logger):
         ephemeral_5m = cache_creation.ephemeral_5m_input_tokens
         ephemeral_1h = cache_creation.ephemeral_1h_input_tokens
 
-    spans = memory_logger.pop()
-    assert len(spans) == 1
-    span = spans[0]
-    assert span["metadata"]["model"] == MODEL
-    assert span["metadata"]["provider"] == "anthropic"
     assert span["metadata"]["usage_service_tier"] == usage.service_tier
     assert span["metadata"]["usage_inference_geo"] == usage.inference_geo
     metrics = span["metrics"]
@@ -609,6 +611,13 @@ def test_extract_anthropic_usage_preserves_nested_numeric_fields():
     }
 
 
+def test_extract_anthropic_usage_skips_empty_usage():
+    metrics, metadata = extract_anthropic_usage(SimpleNamespace())
+
+    assert metrics == {}
+    assert metadata == {}
+
+
 def _make_batch_requests():
     return [
         {