-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add Release Notes for iOS Release 1.84 [Changelog] #50927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kjozwiak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes/nits needed.
Thanks for the review, good suggestions as always |
📋 Code Owners Summary1 file(s) changed
1 team(s) affected: @brave/uplift-approvers Owners and Their Files@brave/uplift-approvers — 1 file(s) |
kjozwiak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Nice work @Uni-verse.
Resolves #50926
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
N/A