Skip to content

Conversation

@Uni-verse
Copy link
Contributor

Resolves #50926

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

N/A

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes/nits needed.

@Uni-verse
Copy link
Contributor Author

Some changes/nits needed.

Thanks for the review, good suggestions as always

@github-actions
Copy link

📋 Code Owners Summary

1 file(s) changed

  • 1 with assigned owners

1 team(s) affected: @brave/uplift-approvers


Owners and Their Files

@brave/uplift-approvers — 1 file(s)

@Uni-verse Uni-verse enabled auto-merge (squash) November 21, 2025 21:46
@Uni-verse Uni-verse requested a review from kjozwiak November 21, 2025 21:46
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Nice work @Uni-verse.

@Uni-verse Uni-verse merged commit a6e8312 into master Nov 21, 2025
4 checks passed
@Uni-verse Uni-verse deleted the smesher-ios-release-notes-1.84 branch November 21, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release Notes for iOS Release 1.84

3 participants