Child window support for macOS

Author: dancasarin

include/brisk/graphics/NativeWindowHandle.hpp

@@ -63,10 +63,30 @@ struct NativeWindowHandle {
 #ifdef BRISK_APPLE
 #if defined(__OBJC__)
     NSWindow* nsWindow() const noexcept {
-        return (__bridge NSWindow*)ptr;
+        if (ptr == nullptr)
+            return nullptr;
+        if (isNsWindow())            
+            return (__bridge NSWindow*)ptr;
+        return [(__bridge NSView*)ptr window];
+    }
+
+    NSView* nsView() const noexcept {
+        if (ptr == nullptr)
+            return nullptr;
+        return (__bridge NSView*)ptr;
+    }
+
+    bool isNsWindow() const noexcept {
+        return ptr != nullptr && [((__bridge id)ptr) isKindOfClass:[NSWindow class]];
+    }
+
+    bool isNsView() const noexcept {
+        return ptr != nullptr && [((__bridge id)ptr) isKindOfClass:[NSView class]];
     }
 
     explicit NativeWindowHandle(NSWindow* nsWindow) noexcept : ptr((__bridge void*)nsWindow) {}
+
+    explicit NativeWindowHandle(NSView* nsView) noexcept : ptr((__bridge void*)nsView) {}
 #endif
 #endif
 

src/graphics/WebGpuRenderer/WindowRenderTarget_Darwin.mm

@@ -30,8 +30,15 @@
     ensureOnRenderThread();
     @autoreleasepool {
         NativeWindowHandle handle = window->getHandle();
-        NSWindow* nsWindow        = handle.nsWindow();
-        NSView* view              = [nsWindow contentView];
+        NSWindow* nsWindow;
+        NSView* view;
+        if (handle.isNsWindow()) {
+            nsWindow = handle.nsWindow();
+            view     = [nsWindow contentView];
+        } else {
+            nsWindow = handle.nsWindow();
+            view     = handle.nsView();
+        }
 
         [view setWantsLayer:YES];
         [view setLayer:[CAMetalLayer layer]];

src/window/PlatformWindow.hpp

@@ -108,7 +108,7 @@ class PlatformWindow {
 
     Bytes placement() const;
     void setPlacement(BytesView data);
-    explicit PlatformWindow(Window* window, Size windowSize, Point position, WindowStyle style);
+    explicit PlatformWindow(Window* window, Size windowSize, Point position, WindowStyle style, NativeWindowHandle parent);
     bool createWindow();
 
     void setTitle(std::string_view title);
@@ -117,7 +117,6 @@ class PlatformWindow {
     void setSizeLimits(Size minSize, Size maxSize);
     void setStyle(WindowStyle style);
     void setOwner(Rc<Window> window);
-    void setParent(NativeWindowHandle parent);
     void releaseButtonsAndKeys();
 
     NativeWindowHandle getHandle() const;