fix rector and CS

Author: LordSimal

composer.json

@@ -65,7 +65,7 @@
         "illuminate": "bin/cake illuminate code",
         "phpstan": "phpstan analyse",
         "phpstan-baseline": "phpstan --generate-baseline",
-        "rector-setup": "cp composer.json composer.backup && composer require --dev rector/rector:\"~2.3.1\" && mv composer.backup composer.json",
+        "rector-setup": "cp composer.json composer.backup && composer require --dev rector/rector:\"~2.6.1\" && mv composer.backup composer.json",
         "rector-check": "vendor/bin/rector process --dry-run",
         "rector-fix": "vendor/bin/rector process"
     }

composer.lock

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Cake\Cache\Engine\FileEngine;
 use Cake\Database\Connection;
 use Cake\Database\Driver\Mysql;
@@ -13,7 +15,7 @@
     FILTER_VALIDATE_BOOL,
 );
 $trustedProxyIps = array_values(array_filter(array_map(
-    'trim',
+    trim(...),
     explode(',', (string)env('TRUSTED_PROXY_IPS', '172.17.0.1')),
 )));
 

config/app.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use function Cake\Core\env;
 
 /*

config/app_local.example.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * CakePHP(tm) : Rapid Development Framework (https://cakephp.org)
  * Copyright (c) Cake Software Foundation, Inc. (https://cakefoundation.org)

config/paths.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /**
  * Plugin configuration.
  *
@@ -18,15 +21,14 @@
  * @since         5.0.0
  * @license       https://opensource.org/licenses/mit-license.php MIT License
  */
-
- /*
-  * List of plugins to load in the form `PluginName` => `[configuration options]`.
-  *
-  * Available options:
-  * - onlyDebug: Load the plugin only in debug mode. Default false.
-  * - onlyCli: Load the plugin only in CLI mode. Default false.
-  * - optional: Do not throw an exception if the plugin is not found. Default false.
-  */
+/*
+ * List of plugins to load in the form `PluginName` => `[configuration options]`.
+ *
+ * Available options:
+ * - onlyDebug: Load the plugin only in debug mode. Default false.
+ * - onlyCli: Load the plugin only in CLI mode. Default false.
+ * - optional: Do not throw an exception if the plugin is not found. Default false.
+ */
 return [
     'DebugKit' => ['onlyDebug' => true],
     'Bake' => ['onlyCli' => true, 'optional' => true],

config/plugins.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * Routes configuration.
  *

config/routes.php

@@ -60,7 +60,6 @@
         CompactToVariablesRector::class,
         SplitDoubleAssignRector::class,
         ChangeOrIfContinueToMultiContinueRector::class,
-        ExplicitBoolCompareRector::class,
         NewlineBeforeNewAssignSetRector::class,
         DisallowedEmptyRuleFixerRector::class,
         RemoveUselessParamTagRector::class,

rector.php

@@ -270,7 +270,7 @@ private function getDataForPackage(string $packageName): array
     }
 
     /**
-     * @return \Cake\I18n\Date|null
+     * Extract the release date
      */
     private function extractReleaseDate(?Version $version): ?Date
     {

src/Command/SyncPackagesCommand.php

@@ -47,7 +47,6 @@ public function initialize(): void
      * Displays a view
      *
      * @param string ...$path Path segments.
-     * @return \Cake\Http\Response|null
      * @throws \Cake\Http\Exception\ForbiddenException When a directory traversal attempt.
      * @throws \Cake\View\Exception\MissingTemplateException When the view file could not
      *   be found and in debug mode.