From 53ee4040aa8bffaa8a28f81af3a7af9b62d68794 Mon Sep 17 00:00:00 2001 From: Jeff Nelson Date: Sat, 12 Apr 2025 12:23:32 -0400 Subject: [PATCH 1/3] add TODO note for search... --- .../com/cinchapi/concourse/server/storage/db/Database.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/concourse-server/src/main/java/com/cinchapi/concourse/server/storage/db/Database.java b/concourse-server/src/main/java/com/cinchapi/concourse/server/storage/db/Database.java index 91fbe2c7f..e9b42dd80 100644 --- a/concourse-server/src/main/java/com/cinchapi/concourse/server/storage/db/Database.java +++ b/concourse-server/src/main/java/com/cinchapi/concourse/server/storage/db/Database.java @@ -731,6 +731,10 @@ public Map> review(String key, long record) { @Override public Set search(String key, String query) { + // TODO: should we consider first checking if the index for key is in + // memory and using that instead of loading the corpus record. If + // ENABLE_SEARCH_CACHE is true then also check if there exist caches for + // key? // NOTE: Locking must happen here since CorpusRecords are not cached and // search potentially works across multiple ones. masterLock.readLock().lock(); From cfba3e1cf94b091c67ed6e90f7ec14ab2fd51a33 Mon Sep 17 00:00:00 2001 From: Jeff Nelson Date: Sat, 12 Apr 2025 12:24:37 -0400 Subject: [PATCH 2/3] Revert "add TODO note for search..." This reverts commit 53ee4040aa8bffaa8a28f81af3a7af9b62d68794. --- .../com/cinchapi/concourse/server/storage/db/Database.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/concourse-server/src/main/java/com/cinchapi/concourse/server/storage/db/Database.java b/concourse-server/src/main/java/com/cinchapi/concourse/server/storage/db/Database.java index e9b42dd80..91fbe2c7f 100644 --- a/concourse-server/src/main/java/com/cinchapi/concourse/server/storage/db/Database.java +++ b/concourse-server/src/main/java/com/cinchapi/concourse/server/storage/db/Database.java @@ -731,10 +731,6 @@ public Map> review(String key, long record) { @Override public Set search(String key, String query) { - // TODO: should we consider first checking if the index for key is in - // memory and using that instead of loading the corpus record. If - // ENABLE_SEARCH_CACHE is true then also check if there exist caches for - // key? // NOTE: Locking must happen here since CorpusRecords are not cached and // search potentially works across multiple ones. masterLock.readLock().lock(); From 1209bed87644d4cd6be6ed228578a584265dbad7 Mon Sep 17 00:00:00 2001 From: Jeff Nelson Date: Sat, 12 Apr 2025 12:25:19 -0400 Subject: [PATCH 3/3] Add TODO note It might only make sense to do this when ENABLE_SEARCH_CACHE is enabled as an optimization. Otherwise, the search index is never in memory and the index likely is so the search indexes will never be used. Which might defeat the purpose --- .../com/cinchapi/concourse/server/storage/db/Database.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/concourse-server/src/main/java/com/cinchapi/concourse/server/storage/db/Database.java b/concourse-server/src/main/java/com/cinchapi/concourse/server/storage/db/Database.java index 91fbe2c7f..e9b42dd80 100644 --- a/concourse-server/src/main/java/com/cinchapi/concourse/server/storage/db/Database.java +++ b/concourse-server/src/main/java/com/cinchapi/concourse/server/storage/db/Database.java @@ -731,6 +731,10 @@ public Map> review(String key, long record) { @Override public Set search(String key, String query) { + // TODO: should we consider first checking if the index for key is in + // memory and using that instead of loading the corpus record. If + // ENABLE_SEARCH_CACHE is true then also check if there exist caches for + // key? // NOTE: Locking must happen here since CorpusRecords are not cached and // search potentially works across multiple ones. masterLock.readLock().lock();