test(adapters/slack): assert history request forms and order across pages

Author: ethanndickson

adapters/slack/history_hardening_test.go

@@ -50,16 +50,15 @@ func slackHistoryReaderFor(t *testing.T, bot *chat.Chat) chat.HistoryReader {
 	return hr
 }
 
-// A history read inherits the adapter Observation Hook: the shared callWithToken
-// seam emits ObsAdapterCall around the platform read, so observability is uniform
-// with every other adapter API call (ADR 0010 + ADR 0009).
+// A history read inherits the adapter Observation Hook: the adapter's slackapi
+// client emits ObsAdapterCall around the platform read, as it does for every other
+// adapter API call (ADR 0010 + ADR 0009).
 func TestSlackReadHistoryEmitsAdapterCallObservation(t *testing.T) {
 	t.Parallel()
 
 	api := newSlackAPIServer(t)
-	api.historyResp = map[string]any{
-		"ok":       true,
-		"messages": []any{map[string]any{"type": "message", "user": "U1", "text": "hi", "ts": "111.000", "thread_ts": "111.000"}},
+	api.historyMessages = []map[string]any{
+		{"type": "message", "user": "U1", "text": "hi", "ts": "111.000", "thread_ts": "111.000"},
 	}
 	obs := &countingObserver{}
 	bot := newSlackHistoryRuntimeWithObserver(t, api.URL, api.Client(), obs)
@@ -171,41 +170,6 @@ func TestSlackReadHistoryDeadlineBounded(t *testing.T) {
 	}
 }
 
-// The direct-message path (conversations.history) honors Before (latest=<ts>,
-// inclusive=false) and clamped limit together, proving cursor + clamping are wired
-// on both read paths, not only conversations.replies.
-func TestSlackReadHistoryDirectCursorAndClamp(t *testing.T) {
-	t.Parallel()
-
-	api := newSlackAPIServer(t)
-	bot := newSlackHistoryRuntimeWithObserver(t, api.URL, api.Client(), nil)
-	hr := slackHistoryReaderFor(t, bot)
-
-	id := slack.EncodeDirectThreadIDForTest("T1", "D1")
-	if _, err := hr.ReadHistory(context.Background(), id, chat.HistoryQuery{Limit: 9000, Before: "222.000"}); err != nil {
-		t.Fatalf("read history: %v", err)
-	}
-	if len(api.historyReqs) != 1 {
-		t.Fatalf("history requests = %d, want 1", len(api.historyReqs))
-	}
-	req := api.historyReqs[0]
-	if req.Method != "/conversations.history" {
-		t.Fatalf("method = %q, want conversations.history", req.Method)
-	}
-	if req.Channel != "D1" {
-		t.Fatalf("channel = %q, want D1", req.Channel)
-	}
-	if req.TS != "" {
-		t.Fatalf("conversations.history carried ts = %q, want empty (no thread root)", req.TS)
-	}
-	if req.Latest != "222.000" || req.Inclusive {
-		t.Fatalf("cursor mapping = latest %q inclusive %v, want 222.000/false", req.Latest, req.Inclusive)
-	}
-	if req.Limit != 1000 {
-		t.Fatalf("limit = %d, want clamped 1000", req.Limit)
-	}
-}
-
 // Golden multi-message payload: Slack returns thread replies oldest-first with the
 // root first, and ReadHistory returns them newest-first with the root last, the
 // bot's own message normalizes to BotBot with the bot user ID, history Messages are
@@ -215,14 +179,11 @@ func TestSlackReadHistoryGoldenPayloadNormalization(t *testing.T) {
 	t.Parallel()
 
 	api := newSlackAPIServer(t)
-	api.historyResp = map[string]any{
-		"ok": true,
-		"messages": []any{
-			map[string]any{"type": "message", "user": "U1", "text": "root", "ts": "111.000", "thread_ts": "111.000"},
-			map[string]any{"type": "message", "user": "U2", "text": "<@UBOT> hey", "ts": "112.000", "thread_ts": "111.000", "edited": map[string]any{"user": "U2", "ts": "112.100"}},
-			map[string]any{"type": "message", "bot_id": "BOTHER", "subtype": "bot_message", "text": "another bot", "ts": "112.500", "thread_ts": "111.000"},
-			map[string]any{"type": "message", "user": "UBOT", "text": "I am the bot", "ts": "113.000", "thread_ts": "111.000"},
-		},
+	api.historyMessages = []map[string]any{
+		{"type": "message", "user": "U1", "text": "root", "ts": "111.000", "thread_ts": "111.000"},
+		{"type": "message", "user": "U2", "text": "<@UBOT> hey", "ts": "112.000", "thread_ts": "111.000", "edited": map[string]any{"user": "U2", "ts": "112.100"}},
+		{"type": "message", "bot_id": "BOTHER", "subtype": "bot_message", "text": "another bot", "ts": "112.500", "thread_ts": "111.000"},
+		{"type": "message", "user": "UBOT", "text": "I am the bot", "ts": "113.000", "thread_ts": "111.000"},
 	}
 	bot := newSlackHistoryRuntimeWithObserver(t, api.URL, api.Client(), nil)
 	hr := slackHistoryReaderFor(t, bot)