From bc063e3ccad3d5bfd9f0c86662b82bf730eaa465 Mon Sep 17 00:00:00 2001 From: Thomas Kosiewski Date: Sat, 10 Oct 2026 01:46:58 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=A4=96=20ci:=20keep=20stderr=20out=20of?= =?UTF-8?q?=20the=20cold-start=20JSON=20artifact?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/desktop-cold-start.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/desktop-cold-start.yml b/.github/workflows/desktop-cold-start.yml index 4973f471289..837a3892d0f 100644 --- a/.github/workflows/desktop-cold-start.yml +++ b/.github/workflows/desktop-cold-start.yml @@ -37,7 +37,10 @@ jobs: cd "$RUNNER_TEMP/base" && bun install --frozen-lockfile && make build - name: Run cold-start A/B env: { ELECTRON_DISABLE_SANDBOX: 1 } - run: xvfb-run -a node --import tsx scripts/perf/desktopColdStart.ts --base "$RUNNER_TEMP/base" --head "$GITHUB_WORKSPACE" --pairs "$PAIRS" --json > cold-start.json + # Redirect inside sh -c: Ubuntu 22.04's xvfb-run runs the command with 2>&1, which mixed progress lines into the JSON. + run: | + # shellcheck disable=SC2016 # the inner sh -c expands these + xvfb-run -a sh -c 'node --import tsx scripts/perf/desktopColdStart.ts --base "$RUNNER_TEMP/base" --head "$GITHUB_WORKSPACE" --pairs "$PAIRS" --json > cold-start.json' - uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0 if: always() with: