Follow redirects

[Zuruuh]

This seems like a reasonable feature to implement to be on-par with reqwest. I think having a similar api as reqwest::redirect::Policy added to the ClientBuilder/Client should be fine. I can try implementing this feature as well 🙂

Edit: after looking into it a bit more it might be a bit more complicated than I thought 😅 Though I'm still interested

[Berrysoft]

OK. PR is welcome.

[Zuruuh]

After investigating a bit I realized that this task is indeed not trivial. From what I've seen, reqwest uses tower-http to handle all the logic related to following redirections (See https://github.com/seanmonstar/reqwest/blob/master/Cargo.toml#L131 and https://github.com/seanmonstar/reqwest/blob/master/src/redirect.rs#L16), and reproduces the API that tower-http uses to consumers. Do you think adding tower-http as a dependency for the project would be fine ? Should we gate it behind a feature flag maybe ?

[Berrysoft]

I think tower-http is ok, but we need a feature gate.

[Zuruuh]

Some update, I tried multiple ways but I am not really familiar with tower nor any of it's sub packages so I didn't get really far. I'm not sure I can implement this myself really, the biggest issue I've been having is knowing when to clone the request body before sending it so we can re-send it if needed afterwards; this induces quite some overhead for most cases 🤷

[Berrysoft]

Then you might want to put the body into an Rc or Arc?

[umbrageodotus]

What if we just add middleware support to cyper? Then people can use their own tower-http middleware... or maybe that's too much and at that point a rewrite should be done for focusing on middleware.

[Berrysoft]

I think it's a good idea to implement tower Service for cyper Client.