fix: remove openssl dependency to fix Linux release builds#317
Conversation
Bump cooklang-sync-client from 0.4.8 to 0.4.11, which uses rustls-tls instead of default-tls (native-tls/OpenSSL). This eliminates the openssl-sys dependency that was causing all Linux release builds to fail in CI since cross-compilation containers lack OpenSSL dev libraries. Also removes native-tls from dev-dependency reqwest for consistency.
Code ReviewThis is a clean, well-scoped fix that addresses a real CI problem. The approach is sound — swapping ✅ What's good
🔍 Things worth checking
# Before
reqwest = { version = "0.12", features = ["json", "rustls-tls"] }
# After
reqwest = { version = "0.12", default-features = false, features = ["json", "rustls-tls"] }
The Cargo.lock diff shows
pub struct SyncHandle {
context: Arc<SyncContext>,
...
}If SummaryThis is a good fix. The |
Summary
cooklang-sync-clientfrom 0.4.8 to 0.4.11 which usesrustls-tlsinstead ofdefault-tls(native-tls/OpenSSL)native-tlsfrom dev-dependencyreqwestfor consistencyrunner.rsto match newcooklang-sync-client0.4.11 API (SyncContextreplaces rawCancellationToken)This eliminates
openssl-sysand ~15 related crates from the dependency tree, fixing all 5 failing Linux targets in the release workflow and reducing binary size.Test plan
cargo fmt -- --checkpassescargo clippy --all-targets --all-features -- -D warningspassescargo testpassesnative-tlsandopenssl-sysare absent fromcargo tree -e no-dev