Cannot get copilot to use 4 spaces to indent Python

[kynnjo]

I have run all of the following:

    (setq python-indent-offset 4)
    (add-to-list 'copilot-indentation-alist '(prog-mode 4))
    (add-to-list 'copilot-indentation-alist '(python-mode 4))
    (setq-default indent-tabs-mode nil)

(My tab-width variable is set to 8, and that is where I want to keep it. Since I don't want TABs in my Python code, at all, this setting should not matter.)

To no avail: all the code that Copilot proposes still uses an 8-space indentation.

What else must I do to get Copilot to use 4-spaces/level for indenting Python code?

[bbatsov]

Hmm, but this indentation configuration works properly in Python mode?

Do you have some editorconfig in your project?

[kynnjo]

@bbatsov : Yes, if I turn off copilot-mode, Python indentation works fine. (I.e., I hit tab to increase/decrease indentation by 4 spaces at a time.)

Regarding your second question, I don't have editorconfig installed. Is that what you where referring to?

[masonkatz]

I'm seeing the same thing. I'm also doing 4 spaces indentation and w/o copilot-mode everything is fine.

Interestingly

 (copilot--generate-doc)

Returns (I removed the :file and :uri values) the following:

(:version 16 :tabSize 8 :indentSize 4 :insertSpaces t 

		  :relativePath "render.py" :languageId "python" :position
		  (:line 9 :character 32))

Which is correct but copilot still returns 8 spaces indented code. But if I set tab-width to 4 in my python-mode-hook copilot does the right thing and respects the :indentSize and :insertSpaces vars and returns 4 spaces indented code.

[kynnjo]

@masonkatz: Thank you! It looks like, somehow, copilot-mode is using tab-width for indenting code.

I really don't like the idea of changing tab-width, though, since it affects more than code indentation.

The question is: why is copilot-mode ignoring its own indentSize?

[masonkatz]

With tab-width=8 I just opened a new python file and typed def fib: <return> and got 8 spaces indented code. I ran copilot-language-server with the --debug flag.

Here's a partial log from the language server:

[streamChoices] choice {
  text: '   ',
  index: 0,
  finish_reason: null,
  logprobs: null,
  p: 'aaaa'
}
[streamChoices] choice {
  text: ' """',
  index: 0,
  finish_reason: null,
  logprobs: null,
  p: 'aaa'
}
[streamChoices] choice {
  text: 'Return',
  index: 0,
  finish_reason: null,
  logprobs: null,
  p: 'a'
}
[streamChoices] choice {
  text: ' the',
  index: 0,
  finish_reason: null,
  logprobs: null,
  p: 'aaa'
}
[streamChoices] choice {
  text: ' Fibonacci',
  index: 0,
  finish_reason: null,
  logprobs: null,
  p: 'aaaaa'
}

Which looks like the language server is return 4 spaces for indentation.

But, when I instrument the copilot-complete function to message out the completions returned from the jsonrpc I see 8 spaces, like this:

copilot-complete [(:uuid "4fad7d53-3852-4b8a-a883-bf448f3c7754" :text "        \"\"\"Return the nth Fibonacci number.\"\"\"" :range (:start (:line 1 :character 0) :end (:line 1 :character 4)) :displayText "\"\"\"Return the nth Fibonacci number.\"\"\"" :position (:line 1 :character 4) :docVersion 215)]

I'm guessing other clients always set the tabSize to the same value as indentSize when insertSpaces is true.

[masonkatz]

The VIM package only sets tabSize and insertSpaces

https://github.com/github/copilot.vim/blob/release/autoload/copilot.vim#L170

indentSize is probably an alias for tabSize

[masonkatz]

• The copilot language server docs make no mention of indentSize only tabSize
• The minified server main.js refers to tabSize with no mention of indentSize
• The LSP spec also only mentions tabSize

So the question is where did this variable come from?

• The usage of both tabSize and indentSize goes back to the first commit in this repo
• Before fix: use standard-indent instead of tab-width #335 tabSize and indentSize had the same value
• Prior to this Python indentation was correct even with tab-width set to 8

[bbatsov]

Yeah, it seems we'll need to fix this. PR welcome!