Skip to content

Commit 14d81cd

Browse files
committed
s
1 parent 78a41d2 commit 14d81cd

3 files changed

Lines changed: 9 additions & 6 deletions

File tree

cli/CMakeLists.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,19 +50,19 @@ if (BUILD_CLI)
5050
# TODO: leverage CMAKE_INSTALL_DATAROOTDIR (share)?
5151

5252
install(FILES ${addons_py}
53-
DESTINATION ${FILESDIR_DEF}/addons
53+
DESTINATION ${FILESDIR_INSTALL}/addons
5454
COMPONENT headers)
5555

5656
install(FILES ${addons_json}
57-
DESTINATION ${FILESDIR_DEF}/addons
57+
DESTINATION ${FILESDIR_INSTALL}/addons
5858
COMPONENT headers)
5959

6060
install(FILES ${cfgs}
61-
DESTINATION ${FILESDIR_DEF}/cfg
61+
DESTINATION ${FILESDIR_INSTALL}/cfg
6262
COMPONENT headers)
6363

6464
install(FILES ${platforms}
65-
DESTINATION ${FILESDIR_DEF}/platforms
65+
DESTINATION ${FILESDIR_INSTALL}/platforms
6666
COMPONENT headers)
6767

6868
# TODO: install manpage into CMAKE_INSTALL_MANDIR

cmake/options.cmake

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,11 @@ set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${PROJECT_BINARY_DIR}/lib)
145145

146146
string(LENGTH "${FILESDIR}" _filesdir_len)
147147
# override FILESDIR if it is set or empty
148+
# needs to be an absolute path in Cppcheck but a relative one for CMake install
148149
if(FILESDIR OR ${_filesdir_len} EQUAL 0)
149-
# TODO: verify that it is an absolute path?
150+
set(FILESDIR_INSTALL "${FILESDIR}") # TODO: make relative - leverage CMAKE_INSTALL_DATAROOTDIR?
150151
set(FILESDIR_DEF "${FILESDIR}")
151152
else()
152-
set(FILESDIR_DEF ${CMAKE_INSTALL_PREFIX}/share/${PROJECT_NAME} CACHE STRING "Cppcheck files directory")
153+
set(FILESDIR_INSTALL "share/${PROJECT_NAME}")
154+
set(FILESDIR_DEF "${CMAKE_INSTALL_PREFIX}/${FILESDIR_INSTALL}")
153155
endif()

cmake/printInfo.cmake

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ message(STATUS)
110110
message(STATUS "USE_LIBCXX = ${USE_LIBCXX}")
111111
message(STATUS)
112112
message(STATUS "FILESDIR = ${FILESDIR}")
113+
message(STATUS "FILESDIR_INSTALL = ${FILESDIR_INSTALL}")
113114
message(STATUS "FILESDIR_DEF = ${FILESDIR_DEF}")
114115
message(STATUS)
115116

0 commit comments

Comments
 (0)