Use std::tranfsorm for inserting library defines

Author: glankk

lib/cppcheck.cpp

@@ -61,6 +61,7 @@
 #include <exception> // IWYU pragma: keep
 #include <fstream>
 #include <iostream>
+#include <iterator>
 #include <map>
 #include <new>
 #include <set>
@@ -1049,8 +1050,10 @@ unsigned int CppCheck::checkInternal(const FileWithDetails& file, const std::str
         std::set<std::string> configDefines = { "__cplusplus" };
 
         // Insert library defines
-        for (const auto &define : mSettings.library.defines())
-            configDefines.insert(define.substr(0, define.find_first_of("( ")));
+        std::transform(mSettings.library.defines().begin(),
+                       mSettings.library.defines().end(),
+                       std::inserter(configDefines, configDefines.end()),
+                       [](const auto &define) { return define.substr(0, define.find_first_of("( ")); });
 
         preprocessor.setLoadCallback([&](simplecpp::FileData &data) {
             // Do preprocessing on included file

test/testpreprocessor.cpp

@@ -33,6 +33,7 @@
 #include "helpers.h"
 
 #include <cstring>
+#include <iterator>
 #include <list>
 #include <map>
 #include <set>
@@ -401,8 +402,10 @@ class TestPreprocessor : public TestFixture {
         Preprocessor preprocessor(tokens, settings, *this, Standards::Language::C);
         std::set<std::string> configs = { "" };
         std::set<std::string> configDefines = { "__cplusplus" };
-        for (const auto &define : settings.library.defines())
-            configDefines.insert(define.substr(0, define.find_first_of("( ")));
+        std::transform(settings.library.defines().begin(),
+                       settings.library.defines().end(),
+                       std::inserter(configDefines, configDefines.end()),
+                       [](const auto &define) { return define.substr(0, define.find_first_of("( ")); });
         preprocessor.setLoadCallback([&](simplecpp::FileData &data) {
             Preprocessor::removeComments(data.tokens);
             preprocessor.getConfigs(data.filename, data.tokens, configDefines, configs);